From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: samsung: exynos5260: Move struct samsung_cmu_info to init section
Date: Wed, 24 Aug 2016 17:11:09 -0700 [thread overview]
Message-ID: <20160825001109.GO19826@codeaurora.org> (raw)
In-Reply-To: <57BD5CFB.5050500@samsung.com>
On 08/24, Chanwoo Choi wrote:
> On 2016? 08? 24? 13:43, Stephen Boyd wrote:
> > On 08/23, Sylwester Nawrocki wrote:
> >> So the saving is rather insignificant but the patch doesn't make
> >> things worse and I'd say it might be worth applying.
> >>
> >
> > Sounds good. This sort of information should be in the commit
> > text though. Talking about const doesn't make any sense to me.
>
> Do you mean that 'const' is initconst secion?
No. Marking it as initconst in the patch is correct.
> If possible, could you explain the anything
> why you don't make sense about 'const'?
>
I'm just saying that the reasoning to move it from the text
section to the data section shouldn't be because of const. There
should be better reasons to do this, like size benefits.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-25 0:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 2:49 [PATCH 0/2] clk: samsung: Move struct samsung_cmu_info to init section Chanwoo Choi
2016-08-22 2:49 ` [PATCH 1/2] clk: samsung: exynos5260: " Chanwoo Choi
2016-08-23 0:55 ` Stephen Boyd
2016-08-23 2:35 ` Chanwoo Choi
2016-08-23 10:07 ` Sylwester Nawrocki
2016-08-24 4:43 ` Stephen Boyd
2016-08-24 8:38 ` Chanwoo Choi
2016-08-25 0:11 ` Stephen Boyd [this message]
2016-08-25 7:28 ` Chanwoo Choi
2016-08-25 14:43 ` Tomasz Figa
2016-09-01 17:06 ` Sylwester Nawrocki
2016-08-22 2:49 ` [PATCH 2/2] clk: samsung: exynos5410: Use samsung_cmu_register_one() to simplify code Chanwoo Choi
2016-09-01 17:07 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825001109.GO19826@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).