linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes
Date: Sat, 27 Aug 2016 16:38:49 +0100	[thread overview]
Message-ID: <20160827153849.GA1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <87vaymdyal.fsf@belgarion.home>

On Sat, Aug 27, 2016 at 05:30:42PM +0200, Robert Jarzmik wrote:
> Hi Russell,
> 
> With your patch :
>  - lubbock, mainstone and zylonite boards are working correctly
>    => ie. all my boards are working correctly
> 
>  - the message "ifconfig: SIOCSIFHWADDR: Device or resource busy" is still there
>    => this message is here even without your patch, so it's rather not relevant
>    => this message is triggered by an "/sbin/ifconfig eth0 hw ether
>    08:00:3e:26:0a:5b" command
> 
> So from a PXA testing point of view it's all good, ie.
> Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>

Thanks for testing, that's good news.

You'll get "SIOCSIFHWADDR: Device or resource busy" if the device is
already up and has no support for changing the address while the NIC
is "live" - we only program the MAC address when bringing the smc91x
device up (or resetting it after a timeout).

See net/ethernet/eth.c::eth_prepare_mac_addr_change() and smc_enable().

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

      reply	other threads:[~2016-08-27 15:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 14:43 [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Arnd Bergmann
2016-08-25 14:45 ` Arnd Bergmann
2016-08-25 18:02   ` Robert Jarzmik
2016-08-25 22:37     ` Russell King - ARM Linux
2016-08-26  9:41       ` Arnd Bergmann
2016-08-26  9:56         ` Arnd Bergmann
2016-08-26 11:38         ` Russell King - ARM Linux
2016-08-26 12:29           ` Russell King - ARM Linux
2016-08-27 15:30       ` Robert Jarzmik
2016-08-27 15:38         ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160827153849.GA1041@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).