From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx7s-warp: Add Bluetooth support
Date: Mon, 29 Aug 2016 13:57:04 +0800 [thread overview]
Message-ID: <20160829055704.GF30790@tiger> (raw)
In-Reply-To: <1471886526-19251-1-git-send-email-vanessa.maegima@nxp.com>
On Mon, Aug 22, 2016 at 02:22:06PM -0300, Vanessa Maegima wrote:
> WaRP7 has a BCM4343 Bluetooth chip.
>
> Add support for it.
>
> Signed-off-by: Vanessa Maegima <vanessa.maegima@nxp.com>
> ---
> arch/arm/boot/dts/imx7s-warp.dts | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts
> index 92d9c85..6ce8953 100644
> --- a/arch/arm/boot/dts/imx7s-warp.dts
> +++ b/arch/arm/boot/dts/imx7s-warp.dts
> @@ -66,6 +66,16 @@
> startup-delay-us = <200000>;
> };
>
> + reg_bt: bt-reg {
Please name the fixed regulator like regulator-xxx.
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>;
> + regulator-name = "bt_reg";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
Why should it be always-on?
> + };
> +
> sound {
> compatible = "simple-audio-card";
> simple-audio-card,name = "imx7-sgtl5000";
> @@ -228,6 +238,15 @@
> status = "okay";
> };
>
> +&uart3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart3>;
> + assigned-clocks = <&clks IMX7D_UART3_ROOT_SRC>;
> + assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
> + fsl,uart-has-rtscts;
This vendor specific property is deprecated. Please use generic one,
uart-has-rtscts, instead.
> + status = "okay";
> +};
> +
> &usbotg1 {
> dr_mode = "peripheral";
> status = "okay";
> @@ -302,6 +321,16 @@
> >;
> };
>
> + pinctrl_uart3: uart3grp {
> + fsl,pins = <
> + MX7D_PAD_UART3_TX_DATA__UART3_DCE_TX 0x79
> + MX7D_PAD_UART3_RX_DATA__UART3_DCE_RX 0x79
> + MX7D_PAD_UART3_CTS_B__UART3_DCE_CTS 0x79
> + MX7D_PAD_UART3_RTS_B__UART3_DCE_RTS 0x79
> + MX7D_PAD_SD2_DATA3__GPIO5_IO17 0x14 /*BT_REG_ON*/
It should be in a separate pinctrl entry for regulator.
Shawn
> + >;
> + };
> +
> pinctrl_usdhc1: usdhc1grp {
> fsl,pins = <
> MX7D_PAD_SD1_CMD__SD1_CMD 0x59
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2016-08-29 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 17:22 [PATCH] ARM: dts: imx7s-warp: Add Bluetooth support Vanessa Maegima
2016-08-29 5:57 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829055704.GF30790@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).