From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx7s-warp: Let the codec control MCLK pinctrl
Date: Mon, 29 Aug 2016 16:18:10 +0800 [thread overview]
Message-ID: <20160829081810.GK30790@tiger> (raw)
In-Reply-To: <1472148347-504-1-git-send-email-fabio.estevam@nxp.com>
On Thu, Aug 25, 2016 at 03:05:47PM -0300, Fabio Estevam wrote:
> sgtl5000 codec needs MCLK clock to be provided so that it can
> successfully read/write via I2C, so we should better let the
> codec control the pinctrl for such pin.
>
> Thanks to Stefan Agner who provided the fix on Toradex's tree:
> http://git.toradex.com/cgit/linux-toradex.git/commit/?h=toradex_imx_4.1.15_1.0.0_ga-next&id=0a55a7e5f58d46eef0d4d1d357d89e36d0c32fa4
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/boot/dts/imx7s-warp.dts | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx7s-warp.dts b/arch/arm/boot/dts/imx7s-warp.dts
> index 92d9c857..7c3f110e 100644
> --- a/arch/arm/boot/dts/imx7s-warp.dts
> +++ b/arch/arm/boot/dts/imx7s-warp.dts
> @@ -199,6 +199,8 @@
> reg = <0x0a>;
> compatible = "fsl,sgtl5000";
> clocks = <&clks IMX7D_AUDIO_MCLK_ROOT_CLK>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_sai1_mclk>;
> VDDA-supply = <&vgen4_reg>;
> VDDIO-supply = <&vgen4_reg>;
> VDDD-supply = <&vgen2_reg>;
> @@ -291,7 +293,12 @@
> MX7D_PAD_SAI1_TX_BCLK__SAI1_TX_BCLK 0x1f
> MX7D_PAD_SAI1_TX_SYNC__SAI1_TX_SYNC 0x1f
> MX7D_PAD_SAI1_TX_DATA__SAI1_TX_DATA0 0x30
> - MX7D_PAD_SAI1_MCLK__SAI1_MCLK 0x1f
> + >;
> + };
> +
> + pinctrl_sai1_mclk: sai1grp_mclk {
We do not use underscore in node name. I changed it to sai1mclkgrp and
applied the patch.
Shawn
> + fsl,pins = <
> + MX7D_PAD_SAI1_MCLK__SAI1_MCLK 0x1f
> >;
> };
>
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2016-08-29 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 18:05 [PATCH] ARM: dts: imx7s-warp: Let the codec control MCLK pinctrl Fabio Estevam
2016-08-29 8:18 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829081810.GK30790@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox