From: briannorris@chromium.org (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: Explicitly set pclk_pmu_src on rk3399
Date: Mon, 29 Aug 2016 11:18:42 -0700 [thread overview]
Message-ID: <20160829181841.GA8682@localhost> (raw)
In-Reply-To: <1472494284-11315-1-git-send-email-dianders@chromium.org>
On Mon, Aug 29, 2016 at 11:11:24AM -0700, Doug Anderson wrote:
> On rk3399 we explicitly set ppll in the device tree to 676000000. The
> ppll has one major child, pclk_pmu_src, that is the parent of lots of
> other clocks. Right now nobody is setting that clock rate and we're
> relying on the divider to just happen to be something sane. Let's be
> explicit in our request so we're not relying on the firmware.
>
> With the current firmware I tested with this patch has no expected
> impact but it's probably good to do anyway.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 62d450935a57..ffb3faa8c176 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -908,8 +908,8 @@
> reg = <0x0 0xff750000 0x0 0x1000>;
> #clock-cells = <1>;
> #reset-cells = <1>;
> - assigned-clocks = <&pmucru PLL_PPLL>;
> - assigned-clock-rates = <676000000>;
> + assigned-clocks = <&pmucru PLL_PPLL>, <&pmucru PCLK_SRC_PMU>;
> + assigned-clock-rates = <676000000>, <112666667>;
I think this makes sense and is a good idea. One alternative would be to
have the various children actually set a rate that they expect, but
several of them don't have a separate driver at all, and that would be
of dubious value anyway I think.
Reviewed-by: Brian Norris <briannorris@chromium.org>
> };
>
> cru: clock-controller at ff760000 {
> --
> 2.8.0.rc3.226.g39d4020
>
next prev parent reply other threads:[~2016-08-29 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 18:11 [PATCH] arm64: dts: rockchip: Explicitly set pclk_pmu_src on rk3399 Douglas Anderson
2016-08-29 18:18 ` Brian Norris [this message]
2016-08-30 0:59 ` Elaine Zhang
2016-08-30 7:05 ` Heiko Stübner
2016-08-30 17:06 ` Brian Norris
2016-08-30 20:17 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829181841.GA8682@localhost \
--to=briannorris@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).