[PATCH 1/4] ARM: dts: shmobile: remove label property from led

[PATCH 1/4] ARM: dts: shmobile: remove label property from led

[Simon Horman]

Remove label property from led nodes. This seems to have little
value and is used inconsistently amongst Renesas SoCs.

Based on renesas-devel-20160824-v4.8-rc3

Simon Horman (4):
  ARM: dts: armadillo800eva: remove label property from led nodes
  ARM: dts: koelsch: remove label property from led nodes
  ARM: dts: gose: remove label property from led nodes
  ARM: dts: kzm9g: remove label property from led nodes

 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 4 ----
 arch/arm/boot/dts/r8a7791-koelsch.dts         | 3 ---
 arch/arm/boot/dts/r8a7793-gose.dts            | 3 ---
 arch/arm/boot/dts/sh73a0-kzm9g.dts            | 4 ----
 4 files changed, 14 deletions(-)

-- 
2.7.0.rc3.207.g0ac5344

[PATCH 1/4] ARM: dts: armadillo800eva: remove label property from led nodes

[Simon Horman]

Remove label property from led nodes. This seems to have little
value and is used inconsistently amongst Renesas SoCs.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 7885075428bb..12d528dadcb2 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -111,19 +111,15 @@
 		compatible = "gpio-leds";
 		led3 {
 			gpios = <&pfc 102 GPIO_ACTIVE_HIGH>;
-			label = "LED3";
 		};
 		led4 {
 			gpios = <&pfc 111 GPIO_ACTIVE_HIGH>;
-			label = "LED4";
 		};
 		led5 {
 			gpios = <&pfc 110 GPIO_ACTIVE_HIGH>;
-			label = "LED5";
 		};
 		led6 {
 			gpios = <&pfc 177 GPIO_ACTIVE_HIGH>;
-			label = "LED6";
 		};
 	};
 
-- 
2.7.0.rc3.207.g0ac5344

[PATCH 2/4] ARM: dts: koelsch: remove label property from led nodes

[Simon Horman]

Remove label property from led nodes. This seems to have little
value and is used inconsistently amongst Renesas SoCs.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index f8a7d090fd01..92a0658854ca 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -158,15 +158,12 @@
 		compatible = "gpio-leds";
 		led6 {
 			gpios = <&gpio2 19 GPIO_ACTIVE_HIGH>;
-			label = "LED6";
 		};
 		led7 {
 			gpios = <&gpio2 20 GPIO_ACTIVE_HIGH>;
-			label = "LED7";
 		};
 		led8 {
 			gpios = <&gpio2 21 GPIO_ACTIVE_HIGH>;
-			label = "LED8";
 		};
 	};
 
-- 
2.7.0.rc3.207.g0ac5344

[PATCH 3/4] ARM: dts: gose: remove label property from led nodes

[Simon Horman]

Remove label property from led nodes. This seems to have little
value and is used inconsistently amongst Renesas SoCs.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7793-gose.dts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index 90af18600124..c63213c7a173 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -146,15 +146,12 @@
 		compatible = "gpio-leds";
 		led6 {
 			gpios = <&gpio2 19 GPIO_ACTIVE_HIGH>;
-			label = "LED6";
 		};
 		led7 {
 			gpios = <&gpio2 20 GPIO_ACTIVE_HIGH>;
-			label = "LED7";
 		};
 		led8 {
 			gpios = <&gpio2 21 GPIO_ACTIVE_HIGH>;
-			label = "LED8";
 		};
 	};
 
-- 
2.7.0.rc3.207.g0ac5344

[PATCH 4/4] ARM: dts: kzm9g: remove label property from led nodes

[Simon Horman]

Remove label property from led nodes. This seems to have little
value and is used inconsistently amongst Renesas SoCs.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/sh73a0-kzm9g.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/sh73a0-kzm9g.dts b/arch/arm/boot/dts/sh73a0-kzm9g.dts
index 3d65f1f6d78b..fa4b6737eb6a 100644
--- a/arch/arm/boot/dts/sh73a0-kzm9g.dts
+++ b/arch/arm/boot/dts/sh73a0-kzm9g.dts
@@ -88,19 +88,15 @@
 		compatible = "gpio-leds";
 		led1 {
 			gpios = <&pfc 20 GPIO_ACTIVE_LOW>;
-			label = "LED1";
 		};
 		led2 {
 			gpios = <&pfc 21 GPIO_ACTIVE_LOW>;
-			label = "LED2";
 		};
 		led3 {
 			gpios = <&pfc 22 GPIO_ACTIVE_LOW>;
-			label = "LED3";
 		};
 		led4 {
 			gpios = <&pfc 23 GPIO_ACTIVE_LOW>;
-			label = "LED4";
 		};
 	};
 
-- 
2.7.0.rc3.207.g0ac5344

[PATCH 1/4] ARM: dts: shmobile: remove label property from led

[Geert Uytterhoeven]

Hi Simon,

The patch index in the subject should have been 0/4. You're breaking my
script to extract patch series from email threads ;-)

On Fri, Aug 26, 2016 at 3:49 PM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> Remove label property from led nodes. This seems to have little
> value and is used inconsistently amongst Renesas SoCs.
>
> Based on renesas-devel-20160824-v4.8-rc3
>
> Simon Horman (4):
>   ARM: dts: armadillo800eva: remove label property from led nodes
>   ARM: dts: koelsch: remove label property from led nodes
>   ARM: dts: gose: remove label property from led nodes
>   ARM: dts: kzm9g: remove label property from led nodes

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

I assume you are aware this is a user-visible change?
The LED name is exposed under /sys/class/leds/.
Fortunately my LED init script is agnostic to the actual names ;-)

if [ -d /sys/class/leds ]; then
        echo -n Enabling LEDs:
        i=-1
        for led in /sys/class/leds/*; do
                case $i in
                -1)
                        echo -n " heartbeat"
                        echo heartbeat > $led/trigger
                        ;;
                *)
                        if grep -qP "^processor.*: $i$" /proc/cpuinfo; then
                                echo -n " cpu$i"
                                echo cpu$i > $led/trigger
                        fi
                        ;;
                esac
                i=$(($i + 1))
        done
        echo
fi

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 1/4] ARM: dts: shmobile: remove label property from led

[Simon Horman]

On Mon, Aug 29, 2016 at 09:53:23AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> The patch index in the subject should have been 0/4. You're breaking my
> script to extract patch series from email threads ;-)

True. Probably we should not apply this series as its just a clean up
and not worth the risk of breaking user-space.

[PATCH 1/4] ARM: dts: shmobile: remove label property from led

[Geert Uytterhoeven]

Hi Simon,

On Tue, Aug 30, 2016 at 8:52 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Aug 29, 2016 at 09:53:23AM +0200, Geert Uytterhoeven wrote:
>> The patch index in the subject should have been 0/4. You're breaking my
>> script to extract patch series from email threads ;-)

I think you're quoting the wrong part?

> True. Probably we should not apply this series as its just a clean up
> and not worth the risk of breaking user-space.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds