From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Set UTS_MACHINE in the Makefile
Date: Tue, 30 Aug 2016 10:53:23 +0100 [thread overview]
Message-ID: <20160830095322.GA24906@arm.com> (raw)
In-Reply-To: <1472545895-7237-1-git-send-email-mmarek@suse.com>
On Tue, Aug 30, 2016 at 10:31:35AM +0200, Michal Marek wrote:
> The make rpm target depends on proper UTS_MACHINE definition. Also, use
> the variable in arch/arm64/kernel/setup.c, so that it's not accidentally
> removed in the future.
>
> Reported-and-tested-by: Fabian Vogt <fvogt@suse.com>
> Signed-off-by: Michal Marek <mmarek@suse.com>
> ---
What exactly do you mean by "proper", here? Is it just the endianness
suffix that you need?
> arch/arm64/Makefile | 2 ++
> arch/arm64/kernel/Makefile | 2 ++
> arch/arm64/kernel/setup.c | 2 +-
> 3 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 5b54f8c021d8..ab3df36fdfbb 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -38,10 +38,12 @@ ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
> KBUILD_CPPFLAGS += -mbig-endian
> AS += -EB
> LD += -EB
> +UTS_MACHINE := aarch64_be
> else
> KBUILD_CPPFLAGS += -mlittle-endian
> AS += -EL
> LD += -EL
> +UTS_MACHINE := aarch64
> endif
I think we're be better off changing scripts/package/Makefile to map
UTS_MACHINE into whatever rpm requires, just like scripts/package/builddeb
already does this for .deb (which I think ends up broken with your patch
applied).
Will
next prev parent reply other threads:[~2016-08-30 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 8:31 [PATCH] arm64: Set UTS_MACHINE in the Makefile Michal Marek
2016-08-30 9:53 ` Will Deacon [this message]
2016-08-30 10:50 ` Michal Marek
2016-08-30 11:20 ` Will Deacon
2016-08-30 11:53 ` Michal Marek
2016-08-30 14:28 ` [PATCH v2] " Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830095322.GA24906@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).