From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] arm64:ftrace: add save_stack_trace_regs()
Date: Fri, 2 Sep 2016 11:59:24 +0100 [thread overview]
Message-ID: <20160902105924.GA3423@arm.com> (raw)
In-Reply-To: <57C95AE7.5030104@arm.com>
On Fri, Sep 02, 2016 at 11:56:39AM +0100, James Morse wrote:
> On 02/09/16 11:50, James Morse wrote:
> > Hi Pratyush,
> >
> > On 01/09/16 14:35, Pratyush Anand wrote:
> >> Implement save_stack_trace_regs, so that stacktrace of a kprobe events can be
> >> obtained.
> >
> > Hmm, kconfig enables 'CONFIG_KPROBE_EVENT' if we select KPROBES and FTRACE, this
> > calls save_stack_trace_regs(), which we haven't implemented, giving:
> > [ 373.406982] save_stack_trace_regs() not implemented yet.
> > [ 373.413020] ------------[ cut here ]------------
> > [ 373.417601] WARNING: CPU: 1 PID: 0 at ../kernel/stacktrace.c:74 save_stack_tr
> > ace_regs+0x3c/0x48
> > [ 373.426212] Modules linked in:
> > [ 373.429238]
> > [ 373.430716] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.8.0-rc4-dirty #5128
> > [ 373.437606] Hardware name: ARM Juno development board (r1) (DT)
> > [ 373.443466] task: ffff800975dd1900 task.stack: ffff800975ddc000
> > [ 373.449327] PC is at save_stack_trace_regs+0x3c/0x48
> > [ 373.454242] LR is at save_stack_trace_regs+0x3c/0x48
> > [ 373.459156] pc : [<ffff000008126c64>] lr : [<ffff000008126c64>] pstate: 600003c5
> > [ 373.466476] sp : ffff80097ef52c00
> >
> > [ 373.554836] Call trace:
> > [ 373.641153] [<ffff000008126c64>] save_stack_trace_regs+0x3c/0x48
> > [ 373.647104] [<ffff00000817a0b0>] __ftrace_trace_stack+0x168/0x208
> > [ 373.653138] [<ffff00000817ad40>] trace_buffer_unlock_commit_regs+0x5c/0x7c
> > [ 373.659946] [<ffff00000818d57c>] kprobe_trace_func+0x308/0x3d8
> > [ 373.665721] [<ffff00000818defc>] kprobe_dispatcher+0x58/0x60
> > [ 373.671327] [<ffff0000088d8cfc>] kprobe_breakpoint_handler+0xbc/0x18c
> > [ 373.677705] [<ffff0000080851b8>] brk_handler+0x50/0x90
> > [ 373.682792] [<ffff000008081300>] do_debug_exception+0x50/0xbc
> >
> >
> > I guess hitting a WARN_ONCE() while using a 'kernel hacking' feature isn't
> > serious enough to make this a fix.
> >
>
> I wasn't clear enough with the above: this patch is fixing this WARN_ON(), it
> may be worth mentioning that in the commit message...
Yup, please stick that in the commit message without the timestamps and
the addresses, then repost with the CONFIG_FUNCTION_GRAPH_TRACER fixup,
Dave's tested-by and James' ack.
Will
prev parent reply other threads:[~2016-09-02 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 13:35 [PATCH V2] arm64:ftrace: add save_stack_trace_regs() Pratyush Anand
2016-09-01 20:38 ` David Long
2016-09-02 10:50 ` James Morse
2016-09-02 10:56 ` James Morse
2016-09-02 10:59 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902105924.GA3423@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).