* [PATCH] arm-cci: Fix typo in event name
@ 2016-09-02 15:02 Suzuki K Poulose
2016-09-05 14:34 ` Mark Rutland
0 siblings, 1 reply; 3+ messages in thread
From: Suzuki K Poulose @ 2016-09-02 15:02 UTC (permalink / raw)
To: linux-arm-kernel
Fixes a typo in one of the event name for CCI
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
drivers/bus/arm-cci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 5755907f..ffa7c9d 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -551,7 +551,7 @@ static struct attribute *cci5xx_pmu_event_attrs[] = {
CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_wrq, 0xB),
CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_cd_hs, 0xC),
CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_rq_stall_addr_hazard, 0xD),
- CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snopp_rq_stall_tt_full, 0xE),
+ CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_rq_stall_tt_full, 0xE),
CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_rq_tzmp1_prot, 0xF),
NULL
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] arm-cci: Fix typo in event name
2016-09-02 15:02 [PATCH] arm-cci: Fix typo in event name Suzuki K Poulose
@ 2016-09-05 14:34 ` Mark Rutland
2016-09-05 14:38 ` Suzuki K Poulose
0 siblings, 1 reply; 3+ messages in thread
From: Mark Rutland @ 2016-09-05 14:34 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 02, 2016 at 04:02:46PM +0100, Suzuki K Poulose wrote:
> Fixes a typo in one of the event name for CCI
Nit: s/name/names/
Coudl you please expand the commit message to something like:
For one of the CCI events exposed under sysfs, "snoop" was typo'd as
"snopp". Correct this such that users see the expected event name when
enumerating events via sysfs.
With that:
Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/bus/arm-cci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 5755907f..ffa7c9d 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -551,7 +551,7 @@ static struct attribute *cci5xx_pmu_event_attrs[] = {
> CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_wrq, 0xB),
> CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_cd_hs, 0xC),
> CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_rq_stall_addr_hazard, 0xD),
> - CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snopp_rq_stall_tt_full, 0xE),
> + CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_rq_stall_tt_full, 0xE),
> CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_rq_tzmp1_prot, 0xF),
> NULL
> };
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] arm-cci: Fix typo in event name
2016-09-05 14:34 ` Mark Rutland
@ 2016-09-05 14:38 ` Suzuki K Poulose
0 siblings, 0 replies; 3+ messages in thread
From: Suzuki K Poulose @ 2016-09-05 14:38 UTC (permalink / raw)
To: linux-arm-kernel
On 05/09/16 15:34, Mark Rutland wrote:
> On Fri, Sep 02, 2016 at 04:02:46PM +0100, Suzuki K Poulose wrote:
>> Fixes a typo in one of the event name for CCI
>
> Nit: s/name/names/
>
> Coudl you please expand the commit message to something like:
>
> For one of the CCI events exposed under sysfs, "snoop" was typo'd as
> "snopp". Correct this such that users see the expected event name when
> enumerating events via sysfs.
>
> With that:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
Sure, will do.
Thanks
Suzuki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-05 14:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-02 15:02 [PATCH] arm-cci: Fix typo in event name Suzuki K Poulose
2016-09-05 14:34 ` Mark Rutland
2016-09-05 14:38 ` Suzuki K Poulose
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox