From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver
Date: Tue, 6 Sep 2016 17:32:58 -0700 [thread overview]
Message-ID: <20160907003258.GP12510@codeaurora.org> (raw)
In-Reply-To: <CAK7LNAQ9byodJTu-itbnhFrUGDQS5bxYUydyJ3zyZ+aLroQ6FA@mail.gmail.com>
On 09/05, Masahiro Yamada wrote:
> 2016-08-30 3:22 GMT+09:00 Stephen Boyd <sboyd@codeaurora.org>:
> > On 08/29, Masahiro Yamada wrote:
> >> I tried this, but it did not work.
> >>
> >> To make dev_get_regmap() work,
> >> the parent device needs to call dev_regmap_init_mmio() beforehand.
> >>
> >>
> >> Since commit bdb0066df96e74a4002125467ebe459feff1ebef
> >> (mfd: syscon: Decouple syscon interface from platform devices),
> >> syscon_probe() is not called for platform devices,
> >> so that never happens.
> >>
> >
> > Ok. Is the syscon also a simple-mfd?
> >
> > It sounds like there's a device for the parent, but we've failed
> > to attach a regmap to it. Maybe the core DT code should assign
> > the regmap to the parent device when it creates it so that child
> > devices don't need to know this detail? It could look for
> > simple-mfd devices with compatible = "syscon" and then create the
> > regmap? Here's a totally untested patch for that.
> >
>
>
> I was not quire sure about this,
> but maybe worth submitting to DT subsystem?
>
> Anyway, I will go with syscon_node_to_regmap() for v7.
> Of course, I am happy to replace it with dev_get_regmap()
> when the issue is solved in the mainline.
>
Ok that's fine. Did my patch fix dev_get_regmap() for you though?
That would be useful to know so that this patch can be merged in
parallel to yours.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-09-07 0:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 4:30 [PATCH v6 0/2] clk: uniphier: add clock drivers for UniPhier SoCs Masahiro Yamada
2016-08-02 4:30 ` [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver Masahiro Yamada
2016-08-19 0:25 ` Stephen Boyd
2016-08-19 17:46 ` Masahiro Yamada
2016-08-19 19:16 ` Stephen Boyd
2016-08-29 2:21 ` Masahiro Yamada
2016-08-29 18:22 ` Stephen Boyd
2016-09-05 4:02 ` Masahiro Yamada
2016-09-07 0:32 ` Stephen Boyd [this message]
2016-09-16 7:41 ` Masahiro Yamada
2016-08-02 4:30 ` [PATCH v6 2/2] clk: uniphier: add clock data for UniPhier SoCs Masahiro Yamada
2016-08-19 0:28 ` Stephen Boyd
2016-08-19 17:55 ` Masahiro Yamada
-- strict thread matches above, loose matches on Subject: below --
2016-08-02 4:28 [PATCH v6 0/2] clk: uniphier: add clock drivers " Masahiro Yamada
2016-08-02 4:28 ` [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907003258.GP12510@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).