linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] mtd: nand: remove unnecessary 'extern' from function declarations
Date: Wed, 7 Sep 2016 21:29:30 +0200	[thread overview]
Message-ID: <20160907212930.66310fa5@bbrezillon> (raw)
In-Reply-To: <1473250902-31139-8-git-send-email-s.hauer@pengutronix.de>

On Wed,  7 Sep 2016 14:21:42 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:

> 'extern' is not necessary for function declarations. To prevent
> people from adding the keyword to new declarations remove the
> existing ones.
> 

Applied.

Thanks,

Boris

> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  include/linux/mtd/nand.h | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index 9f3d7be..7989178 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -29,26 +29,26 @@ struct nand_flash_dev;
>  struct device_node;
>  
>  /* Scan and identify a NAND device */
> -extern int nand_scan(struct mtd_info *mtd, int max_chips);
> +int nand_scan(struct mtd_info *mtd, int max_chips);
>  /*
>   * Separate phases of nand_scan(), allowing board driver to intervene
>   * and override command or ECC setup according to flash type.
>   */
> -extern int nand_scan_ident(struct mtd_info *mtd, int max_chips,
> +int nand_scan_ident(struct mtd_info *mtd, int max_chips,
>  			   struct nand_flash_dev *table);
> -extern int nand_scan_tail(struct mtd_info *mtd);
> +int nand_scan_tail(struct mtd_info *mtd);
>  
>  /* Free resources held by the NAND device */
> -extern void nand_release(struct mtd_info *mtd);
> +void nand_release(struct mtd_info *mtd);
>  
>  /* Internal helper for board drivers which need to override command function */
> -extern void nand_wait_ready(struct mtd_info *mtd);
> +void nand_wait_ready(struct mtd_info *mtd);
>  
>  /* locks all blocks present in the device */
> -extern int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len);
> +int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len);
>  
>  /* unlocks specified locked blocks */
> -extern int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len);
> +int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len);
>  
>  /* The maximum number of NAND chips in an array */
>  #define NAND_MAX_CHIPS		8
> @@ -1013,14 +1013,14 @@ struct nand_manufacturers {
>  extern struct nand_flash_dev nand_flash_ids[];
>  extern struct nand_manufacturers nand_manuf_ids[];
>  
> -extern int nand_default_bbt(struct mtd_info *mtd);
> -extern int nand_markbad_bbt(struct mtd_info *mtd, loff_t offs);
> -extern int nand_isreserved_bbt(struct mtd_info *mtd, loff_t offs);
> -extern int nand_isbad_bbt(struct mtd_info *mtd, loff_t offs, int allowbbt);
> -extern int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr,
> -			   int allowbbt);
> -extern int nand_do_read(struct mtd_info *mtd, loff_t from, size_t len,
> -			size_t *retlen, uint8_t *buf);
> +int nand_default_bbt(struct mtd_info *mtd);
> +int nand_markbad_bbt(struct mtd_info *mtd, loff_t offs);
> +int nand_isreserved_bbt(struct mtd_info *mtd, loff_t offs);
> +int nand_isbad_bbt(struct mtd_info *mtd, loff_t offs, int allowbbt);
> +int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr,
> +		    int allowbbt);
> +int nand_do_read(struct mtd_info *mtd, loff_t from, size_t len,
> +		 size_t *retlen, uint8_t *buf);
>  
>  /**
>   * struct platform_nand_chip - chip level device structure

      reply	other threads:[~2016-09-07 19:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 12:21 [PATCH v3] mtd: nand: automate NAND timings selection Sascha Hauer
2016-09-07 12:21 ` [PATCH 1/7] mtd: nand: Create a NAND reset function Sascha Hauer
2016-09-07 12:31   ` Boris Brezillon
2016-09-07 12:21 ` [PATCH 2/7] mtd: nand: Introduce nand_data_interface Sascha Hauer
2016-09-07 12:21 ` [PATCH 3/7] mtd: nand: automate NAND timings selection Sascha Hauer
2016-09-07 13:41   ` Boris Brezillon
2016-09-07 14:36     ` Sascha Hauer
2016-09-07 14:59       ` Boris Brezillon
2016-09-07 15:59         ` Boris Brezillon
2016-09-08  7:55           ` Sascha Hauer
2016-09-08  8:12             ` Boris Brezillon
2016-09-07 12:21 ` [PATCH 4/7] mtd: nand: sunxi: switch from manual to automated timing config Sascha Hauer
2016-09-07 12:21 ` [PATCH 5/7] mtd: nand: mxc: implement onfi get/set features Sascha Hauer
2016-09-07 12:21 ` [PATCH 6/7] mtd: nand: mxc: Add timing setup for v2 controllers Sascha Hauer
2016-09-07 12:21 ` [PATCH 7/7] mtd: nand: remove unnecessary 'extern' from function declarations Sascha Hauer
2016-09-07 19:29   ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160907212930.66310fa5@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).