From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] KVM: arm/arm64: arch_timer: remove unused error handling
Date: Thu, 8 Sep 2016 16:25:25 +0200 [thread overview]
Message-ID: <20160908142525.GB9940@cbox> (raw)
In-Reply-To: <20160908135908.1312349-1-arnd@arndb.de>
Hi Arnd,
On Thu, Sep 08, 2016 at 03:58:44PM +0200, Arnd Bergmann wrote:
> A cleanup removed the call to create_singlethread_workqueue(), but did not
> remove the code that was used in case it failed:
>
> virt/kvm/arm/arch_timer.c: In function 'kvm_timer_hyp_init':
> virt/kvm/arm/arch_timer.c:457:1: error: label 'out_free' defined but not used [-Werror=unused-label]
>
> This removes the now dead code too.
Paolo beat you to it:
https://lists.cs.columbia.edu/pipermail/kvmarm/2016-September/021626.html
Thanks,
-Christoffer
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 3706feacd007 ("KVM: Remove deprecated create_singlethread_workqueue")
> ---
> virt/kvm/arm/arch_timer.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c
> index 4309b60ebf17..46980a49a3bb 100644
> --- a/virt/kvm/arm/arch_timer.c
> +++ b/virt/kvm/arm/arch_timer.c
> @@ -453,9 +453,6 @@ int kvm_timer_hyp_init(void)
> cpuhp_setup_state(CPUHP_AP_KVM_ARM_TIMER_STARTING,
> "AP_KVM_ARM_TIMER_STARTING", kvm_timer_starting_cpu,
> kvm_timer_dying_cpu);
> - goto out;
> -out_free:
> - free_percpu_irq(host_vtimer_irq, kvm_get_running_vcpus());
> out:
> return err;
> }
> --
> 2.9.0
>
prev parent reply other threads:[~2016-09-08 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 13:58 [PATCH] KVM: arm/arm64: arch_timer: remove unused error handling Arnd Bergmann
2016-09-08 14:25 ` Christoffer Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908142525.GB9940@cbox \
--to=christoffer.dall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).