* [PATCH] ARM: imx35: add iim module to imx35.dtsi
@ 2016-09-08 9:28 Uwe Kleine-König
2016-09-08 16:21 ` Fabio Estevam
2016-09-09 6:19 ` Shawn Guo
0 siblings, 2 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2016-09-08 9:28 UTC (permalink / raw)
To: linux-arm-kernel
This is a prerequisite to remove the static mappings for imx35 devicetree
based machines.
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/imx35.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
index 490b7b44f1e7..f812d586c5ce 100644
--- a/arch/arm/boot/dts/imx35.dtsi
+++ b/arch/arm/boot/dts/imx35.dtsi
@@ -309,6 +309,13 @@
status = "disabled";
};
+ iim at 53ff0000 {
+ compatible = "fsl,imx35-iim";
+ reg = <0x53ff0000 0x4000>;
+ interrupts = <19>;
+ clocks = <&clks 80>;
+ };
+
usbotg: usb at 53ff4000 {
compatible = "fsl,imx35-usb", "fsl,imx27-usb";
reg = <0x53ff4000 0x0200>;
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: imx35: add iim module to imx35.dtsi
2016-09-08 9:28 [PATCH] ARM: imx35: add iim module to imx35.dtsi Uwe Kleine-König
@ 2016-09-08 16:21 ` Fabio Estevam
2016-09-08 17:55 ` Uwe Kleine-König
2016-09-09 6:19 ` Shawn Guo
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2016-09-08 16:21 UTC (permalink / raw)
To: linux-arm-kernel
Hi Uwe,
On Thu, Sep 8, 2016 at 6:28 AM, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
> This is a prerequisite to remove the static mappings for imx35 devicetree
> based machines.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/boot/dts/imx35.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
> index 490b7b44f1e7..f812d586c5ce 100644
> --- a/arch/arm/boot/dts/imx35.dtsi
> +++ b/arch/arm/boot/dts/imx35.dtsi
> @@ -309,6 +309,13 @@
> status = "disabled";
> };
>
> + iim at 53ff0000 {
> + compatible = "fsl,imx35-iim";
Where is "fsl,imx35-iim" defined?
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: imx35: add iim module to imx35.dtsi
2016-09-08 16:21 ` Fabio Estevam
@ 2016-09-08 17:55 ` Uwe Kleine-König
2016-09-08 18:09 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2016-09-08 17:55 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 08, 2016 at 01:21:49PM -0300, Fabio Estevam wrote:
> Hi Uwe,
>
> On Thu, Sep 8, 2016 at 6:28 AM, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
> > This is a prerequisite to remove the static mappings for imx35 devicetree
> > based machines.
> >
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx35.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
> > index 490b7b44f1e7..f812d586c5ce 100644
> > --- a/arch/arm/boot/dts/imx35.dtsi
> > +++ b/arch/arm/boot/dts/imx35.dtsi
> > @@ -309,6 +309,13 @@
> > status = "disabled";
> > };
> >
> > + iim at 53ff0000 {
> > + compatible = "fsl,imx35-iim";
>
> Where is "fsl,imx35-iim" defined?
right next to the other fsl,imx*-iim :-)
By the way, compared to the other imx*.dtsi I didn't declare
compatibility to fsl,imx27-iim. I checked the i.MX25 reference manual
and the i.MX35 looked different. Didn't check for imx5x and the i.MX27
RM doesn't describe the registers. What do you think?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: imx35: add iim module to imx35.dtsi
2016-09-08 17:55 ` Uwe Kleine-König
@ 2016-09-08 18:09 ` Fabio Estevam
2016-09-08 18:18 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2016-09-08 18:09 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 8, 2016 at 2:55 PM, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
>> Where is "fsl,imx35-iim" defined?
>
> right next to the other fsl,imx*-iim :-)
Ok, "fsl,imx35-iim" is not being used arch/arm/mach-imx/cpu-imx35.c currently.
I suppose you want to replace
"rev = imx_readl(MX35_IO_ADDRESS(MX35_IIM_BASE_ADDR + MXC_IIMSREV));"
by retrieving the base address via dt, like we do in
imx5_read_srev_reg() at arch/arm/mach-imx/cpu-imx5.c.
> By the way, compared to the other imx*.dtsi I didn't declare
> compatibility to fsl,imx27-iim. I checked the i.MX25 reference manual
> and the i.MX35 looked different. Didn't check for imx5x and the i.MX27
> RM doesn't describe the registers. What do you think?
I think this is fine as is, so:
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: imx35: add iim module to imx35.dtsi
2016-09-08 18:09 ` Fabio Estevam
@ 2016-09-08 18:18 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2016-09-08 18:18 UTC (permalink / raw)
To: linux-arm-kernel
Hello Fabio,
On Thu, Sep 08, 2016 at 03:09:17PM -0300, Fabio Estevam wrote:
> On Thu, Sep 8, 2016 at 2:55 PM, Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
>
> >> Where is "fsl,imx35-iim" defined?
> >
> > right next to the other fsl,imx*-iim :-)
>
> Ok, "fsl,imx35-iim" is not being used arch/arm/mach-imx/cpu-imx35.c currently.
>
> I suppose you want to replace
> "rev = imx_readl(MX35_IO_ADDRESS(MX35_IIM_BASE_ADDR + MXC_IIMSREV));"
>
> by retrieving the base address via dt, like we do in
> imx5_read_srev_reg() at arch/arm/mach-imx/cpu-imx5.c.
Yes, that's the plan, imx5_read_srev_reg could even be used for this, so
I intend to rename it and move it to a place where it is compiled for
i.MX[23]5.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: imx35: add iim module to imx35.dtsi
2016-09-08 9:28 [PATCH] ARM: imx35: add iim module to imx35.dtsi Uwe Kleine-König
2016-09-08 16:21 ` Fabio Estevam
@ 2016-09-09 6:19 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2016-09-09 6:19 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 08, 2016 at 11:28:15AM +0200, Uwe Kleine-K?nig wrote:
> This is a prerequisite to remove the static mappings for imx35 devicetree
> based machines.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-09 6:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-08 9:28 [PATCH] ARM: imx35: add iim module to imx35.dtsi Uwe Kleine-König
2016-09-08 16:21 ` Fabio Estevam
2016-09-08 17:55 ` Uwe Kleine-König
2016-09-08 18:09 ` Fabio Estevam
2016-09-08 18:18 ` Uwe Kleine-König
2016-09-09 6:19 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).