* [PATCH] ARM: dts: Add power button support for igepv5
@ 2016-09-09 21:07 Tony Lindgren
2016-09-14 1:26 ` Javier Martinez Canillas
0 siblings, 1 reply; 6+ messages in thread
From: Tony Lindgren @ 2016-09-09 21:07 UTC (permalink / raw)
To: linux-arm-kernel
Add power button support for igepv5.
Cc: Agust? Fontquerni i Gorchs <afontquerni@iseebcn.com>
Cc: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Pau Pajuel <ppajuel@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/boot/dts/omap5-igep0050.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -7,6 +7,7 @@
*/
/dts-v1/;
+#include <dt-bindings/input/input.h>
#include "omap5-board-common.dtsi"
/ {
@@ -17,6 +18,18 @@
device_type = "memory";
reg = <0x80000000 0x7f000000>; /* 2032 MB */
};
+
+ gpio_keys {
+ compatible = "gpio-keys";
+ pinctrl-0 = <&power_button_pin>;
+ pinctrl-names = "default";
+
+ power-button {
+ label = "Power Button";
+ linux,code = <KEY_POWER>;
+ gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
+ };
+ };
};
&hdmi {
@@ -58,6 +71,12 @@
OMAP5_IOPAD(0x0fa, PIN_INPUT | MUX_MODE0) /* i2c4_sda */
>;
};
+
+ power_button_pin: pinctrl_power_button_pin {
+ pinctrl-single,pins = <
+ OMAP5_IOPAD(0x086, PIN_INPUT | MUX_MODE6) /* gpio4_118 */
+ >;
+ };
};
&tpd12s015 {
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: Add power button support for igepv5
2016-09-09 21:07 [PATCH] ARM: dts: Add power button support for igepv5 Tony Lindgren
@ 2016-09-14 1:26 ` Javier Martinez Canillas
2016-09-19 8:13 ` Pau Pajuel
0 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-09-14 1:26 UTC (permalink / raw)
To: linux-arm-kernel
Hello Tony,
On 09/09/2016 05:07 PM, Tony Lindgren wrote:
> Add power button support for igepv5.
>
> Cc: Agust? Fontquerni i Gorchs <afontquerni@iseebcn.com>
> Cc: Enric Balletbo Serra <eballetbo@gmail.com>
> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> Cc: Pau Pajuel <ppajuel@gmail.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
I don't have a schematics for this board, but the patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Add power button support for igepv5
2016-09-14 1:26 ` Javier Martinez Canillas
@ 2016-09-19 8:13 ` Pau Pajuel
2016-09-19 23:08 ` Tony Lindgren
0 siblings, 1 reply; 6+ messages in thread
From: Pau Pajuel @ 2016-09-19 8:13 UTC (permalink / raw)
To: linux-arm-kernel
Hello Tony,
2016-09-14 3:26 GMT+02:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> Hello Tony,
>
> On 09/09/2016 05:07 PM, Tony Lindgren wrote:
>> Add power button support for igepv5.
>>
>> Cc: Agust? Fontquerni i Gorchs <afontquerni@iseebcn.com>
>> Cc: Enric Balletbo Serra <eballetbo@gmail.com>
>> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
>> Cc: Pau Pajuel <ppajuel@gmail.com>
>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>> ---
>
> I don't have a schematics for this board, but the patch looks good to me.
Patch has an errata. Power button is GPIO_ACTIVE_LOW instead GPIO_ACTIVE_HIGH.
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> Best regards,
> --
> Javier Martinez Canillas
> Open Source Group
> Samsung Research America
Best regards
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Add power button support for igepv5
2016-09-19 8:13 ` Pau Pajuel
@ 2016-09-19 23:08 ` Tony Lindgren
2016-09-20 12:15 ` Ladislav Michl
0 siblings, 1 reply; 6+ messages in thread
From: Tony Lindgren @ 2016-09-19 23:08 UTC (permalink / raw)
To: linux-arm-kernel
* Pau Pajuel <ppajuel@gmail.com> [160919 01:13]:
> Hello Tony,
>
> 2016-09-14 3:26 GMT+02:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> > Hello Tony,
> >
> > On 09/09/2016 05:07 PM, Tony Lindgren wrote:
> >> Add power button support for igepv5.
> >>
> >> Cc: Agust? Fontquerni i Gorchs <afontquerni@iseebcn.com>
> >> Cc: Enric Balletbo Serra <eballetbo@gmail.com>
> >> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> >> Cc: Pau Pajuel <ppajuel@gmail.com>
> >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> >> ---
> >
> > I don't have a schematics for this board, but the patch looks good to me.
> Patch has an errata. Power button is GPIO_ACTIVE_LOW instead GPIO_ACTIVE_HIGH.
Oops sorry about that, here's an incremental fix.
Regards,
Tony
8< -----------------------
>From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Mon, 19 Sep 2016 16:02:12 -0700
Subject: [PATCH] ARM: dts: Fix igepv5 power button GPIO direction
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
It should be GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH as
pointed out by Pau Pajuel <ppajuel@gmail.com>.
Cc: Agust? Fontquerni i Gorchs <afontquerni@iseebcn.com>
Cc: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Pau Pajuel <ppajuel@gmail.com>
Fixes: b118c6a6ffa1 ("ARM: dts: Add power button support for igepv5")
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -27,7 +27,7 @@
power-button {
label = "Power Button";
linux,code = <KEY_POWER>;
- gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
+ gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
};
};
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: Add power button support for igepv5
2016-09-19 23:08 ` Tony Lindgren
@ 2016-09-20 12:15 ` Ladislav Michl
2016-09-20 18:39 ` Tony Lindgren
0 siblings, 1 reply; 6+ messages in thread
From: Ladislav Michl @ 2016-09-20 12:15 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Sep 19, 2016 at 04:08:26PM -0700, Tony Lindgren wrote:
> * Pau Pajuel <ppajuel@gmail.com> [160919 01:13]:
> > Hello Tony,
> >
> > 2016-09-14 3:26 GMT+02:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> > > Hello Tony,
> > >
> > > On 09/09/2016 05:07 PM, Tony Lindgren wrote:
> > >> Add power button support for igepv5.
> > >>
> > >> Cc: Agust? Fontquerni i Gorchs <afontquerni@iseebcn.com>
> > >> Cc: Enric Balletbo Serra <eballetbo@gmail.com>
> > >> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> > >> Cc: Pau Pajuel <ppajuel@gmail.com>
> > >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> > >> ---
> > >
> > > I don't have a schematics for this board, but the patch looks good to me.
> > Patch has an errata. Power button is GPIO_ACTIVE_LOW instead GPIO_ACTIVE_HIGH.
>
> Oops sorry about that, here's an incremental fix.
And here's another nitpick ;-)
8< -----------------------
>From 209f676512b5265ab4e9b4efa5a44c281ec2fc71 Mon Sep 17 00:00:00 2001
From: Ladislav Michl <ladis@linux-mips.org>
Date: Tue, 20 Sep 2016 14:09:03 +0200
Subject: [PATCH 2/2] ARM: omap5-igep0050.dts: Use tabs for indentation
Cc: Agust? Fontquerni i Gorchs <afontquerni@iseebcn.com>
Cc: Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Pau Pajuel <ppajuel@gmail.com>
Fixes: b118c6a6ffa1 ("ARM: dts: Add power button support for igepv5")
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
index 139c8f7..44be08a 100644
--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -20,7 +20,7 @@
};
gpio_keys {
- compatible = "gpio-keys";
+ compatible = "gpio-keys";
pinctrl-0 = <&power_button_pin>;
pinctrl-names = "default";
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: Add power button support for igepv5
2016-09-20 12:15 ` Ladislav Michl
@ 2016-09-20 18:39 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2016-09-20 18:39 UTC (permalink / raw)
To: linux-arm-kernel
* Ladislav Michl <ladis@linux-mips.org> [160920 05:15]:
> On Mon, Sep 19, 2016 at 04:08:26PM -0700, Tony Lindgren wrote:
> > * Pau Pajuel <ppajuel@gmail.com> [160919 01:13]:
> > > Hello Tony,
> > >
> > > 2016-09-14 3:26 GMT+02:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> > > > Hello Tony,
> > > >
> > > > On 09/09/2016 05:07 PM, Tony Lindgren wrote:
> > > >> Add power button support for igepv5.
> > > >>
> > > >> Cc: Agust? Fontquerni i Gorchs <afontquerni@iseebcn.com>
> > > >> Cc: Enric Balletbo Serra <eballetbo@gmail.com>
> > > >> Cc: Javier Martinez Canillas <javier@osg.samsung.com>
> > > >> Cc: Pau Pajuel <ppajuel@gmail.com>
> > > >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > >> ---
> > > >
> > > > I don't have a schematics for this board, but the patch looks good to me.
> > > Patch has an errata. Power button is GPIO_ACTIVE_LOW instead GPIO_ACTIVE_HIGH.
> >
> > Oops sorry about that, here's an incremental fix.
>
> And here's another nitpick ;-)
Heh OK thanks, applying both into omap-for-v4.9/dt-v2.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-20 18:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-09 21:07 [PATCH] ARM: dts: Add power button support for igepv5 Tony Lindgren
2016-09-14 1:26 ` Javier Martinez Canillas
2016-09-19 8:13 ` Pau Pajuel
2016-09-19 23:08 ` Tony Lindgren
2016-09-20 12:15 ` Ladislav Michl
2016-09-20 18:39 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).