From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: Regmap regression in next caused by of_iomap change
Date: Mon, 12 Sep 2016 09:55:27 +0100 [thread overview]
Message-ID: <20160912085527.GA1873@dell> (raw)
In-Reply-To: <4088076.eNNe5WgnxT@wuerfel>
On Thu, 08 Sep 2016, Arnd Bergmann wrote:
> On Thursday, September 8, 2016 11:41:12 AM CEST Tony Lindgren wrote:
> > Hi,
> >
> > Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
> > makes at least MMC PBIAS regulator stop working on omap3.
> >
> > That's probably because of_syscon_register uses the now unintialized
> > struct resource res to set syscon_config.max_register.
>
> Looks correct. Lee, please send a revert of that patch to Linus
> along with any other fixes you may have.
No need. It's not in Mainline.
> > I have a strange deja vu feeling that we've been through this
> > before See commit ca668f0edfae ("mfd: syscon: Set regmap max_register
> > in of_syscon_register")
> >
> > Maybe we should add comments there instead?
>
> I wonder why gcc didn't detect this case. I usually do my
> test builds with -Wmaybe-uninitialized that should have
> caught it but didn't.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-09-12 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 18:41 Regmap regression in next caused by of_iomap change Tony Lindgren
2016-09-08 19:59 ` Arnd Bergmann
2016-09-12 8:55 ` Lee Jones [this message]
2016-09-12 8:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912085527.GA1873@dell \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox