linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] ARM: dts: imx28: Fix build warnings with W=1
Date: Mon, 12 Sep 2016 20:09:08 +0800	[thread overview]
Message-ID: <20160912120908.GA7273@tiger> (raw)
In-Reply-To: <20160909091441.01b152ca@ipc1.ka-ro>

On Fri, Sep 09, 2016 at 09:14:41AM +0200, Lothar Wa?mann wrote:
> Hi,
> 
> On Thu, 8 Sep 2016 22:03:38 +0800 Shawn Guo wrote:
> > On Mon, Sep 05, 2016 at 04:27:50PM -0300, Fabio Estevam wrote:
> > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> > > index 0ebbc83..b4d4dbb 100644
> > > --- a/arch/arm/boot/dts/imx28-tx28.dts
> > > +++ b/arch/arm/boot/dts/imx28-tx28.dts
> > > @@ -35,7 +35,8 @@
> > >  		usbotg = &usb0;
> > >  	};
> > >  
> > > -	memory {
> > > +	memory at 0 {
> > > +		device_type = "memory";
> > >  		reg = <0 0>; /* will be filled in by U-Boot */
> > 
> > I'm curious to know if the unit-address will be fixed up or not when
> > 'reg' property gets updated by U-Boot.
> > 
> No. U-Boot does not change the unit name, when updating in the reg
> property. But that does not do any harm (for now), thus the change is
> OK.

This is confusing when people is looking at nodes in /proc/device-tree.
Why cannot we give it a reasonable default configuration instead of
<0 0>?

Shawn

  reply	other threads:[~2016-09-12 12:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05 19:27 [PATCH v2 1/4] ARM: dts: imx23: Remove skeleton.dtsi inclusion Fabio Estevam
2016-09-05 19:27 ` [PATCH v2 2/4] ARM: dts: imx28: " Fabio Estevam
2016-09-05 19:27 ` [PATCH v2 3/4] ARM: dts: imx23: Fix build warnings with W=1 Fabio Estevam
2016-09-12 20:09   ` Stefan Wahren
2016-09-05 19:27 ` [PATCH v2 4/4] ARM: dts: imx28: " Fabio Estevam
2016-09-08 14:03   ` Shawn Guo
2016-09-09  7:14     ` Lothar Waßmann
2016-09-12 12:09       ` Shawn Guo [this message]
2016-09-12 12:24         ` Javier Martinez Canillas
2016-11-04 20:51     ` Fabio Estevam
2016-11-05  7:05       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160912120908.GA7273@tiger \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).