linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL 4/5] Freescale arm64 device tree updates for 4.9
Date: Fri, 16 Sep 2016 09:47:03 +0800	[thread overview]
Message-ID: <20160916014703.GC7398@tiger> (raw)
In-Reply-To: <2241121.MvRjeYAnGC@wuerfel>

On Wed, Sep 14, 2016 at 05:30:49PM +0200, Arnd Bergmann wrote:
> On Monday, September 12, 2016 5:02:27 PM CEST Shawn Guo wrote:
> > i.MX arm64 device tree changes for 4.9:
> >  - Add property dma-coherent for ls2080a PCI device to save software
> >    cache maintenance.
> >  - Update serial aliases and use stdout-path to sepecify console for
> >    ls2080a and ls1043a boards.
> >  - Add DDR memory controller device node for ls2080a and ls1043a SoCs.
> > 
> 
> Pulled into next/dt64, thanks!
> 
> The "dma-coherent" change sounds like a bugfix, should that be backported
> to stable kernels? Usually if you lack that property on a device that
> is actually coherent, you can get silent data corruption by treating it as
> non-coherent.

My impression is that those cache maintenance enforced for non-coherent
device will hurt performance on coherent device.  I don't know it will
cause data corruption.

@Liu Gang,

Did you experience any functional issue with PCI device before adding
"dma-coherent" property?  If not, can you please do more testing to
confirm this is only about performance?  Otherwise, you should follow
Arnd's suggestion to send the change for stable kernel.

Shawn

  reply	other threads:[~2016-09-16  1:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12  9:02 [GIT PULL 1/5] i.MX cleanup for 4.9 Shawn Guo
2016-09-12  9:02 ` [GIT PULL 2/5] i.MX soc updates " Shawn Guo
2016-09-19 14:55   ` Arnd Bergmann
2016-09-12  9:02 ` [GIT PULL 3/5] i.MX device tree " Shawn Guo
2016-09-13 15:43   ` Arnd Bergmann
2016-09-12  9:02 ` [GIT PULL 4/5] Freescale arm64 " Shawn Guo
2016-09-14 15:30   ` Arnd Bergmann
2016-09-16  1:47     ` Shawn Guo [this message]
2016-09-16 13:42       ` Arnd Bergmann
     [not found]         ` <CALRxmdDLRPLr3yD_wGW+3=thr8eZwX4DVGzMad0Gh7n-ERi+og@mail.gmail.com>
2016-09-21 21:57           ` Stuart Yoder
2016-09-12  9:02 ` [GIT PULL 5/5] i.MX defconfig " Shawn Guo
2016-09-14 22:00   ` Arnd Bergmann
2016-09-19 14:48 ` [GIT PULL 1/5] i.MX cleanup " Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916014703.GC7398@tiger \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).