* [PATCH] musb: Export musb_root_disconnect for use in modules
@ 2016-09-16 14:59 Hans de Goede
2016-09-16 15:47 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2016-09-16 14:59 UTC (permalink / raw)
To: linux-arm-kernel
Export musb_root_disconnect for use in modules, so that musb glue
code build as module can use it.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/usb/musb/musb_virthub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/musb_virthub.c b/drivers/usb/musb/musb_virthub.c
index fe08e77..61b5f1c 100644
--- a/drivers/usb/musb/musb_virthub.c
+++ b/drivers/usb/musb/musb_virthub.c
@@ -245,6 +245,7 @@ void musb_root_disconnect(struct musb *musb)
usb_otg_state_string(musb->xceiv->otg->state));
}
}
+EXPORT_SYMBOL_GPL(musb_root_disconnect);
/*---------------------------------------------------------------------*/
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] musb: Export musb_root_disconnect for use in modules
2016-09-16 14:59 [PATCH] musb: Export musb_root_disconnect for use in modules Hans de Goede
@ 2016-09-16 15:47 ` Greg Kroah-Hartman
2016-09-16 15:53 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-16 15:47 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote:
> Export musb_root_disconnect for use in modules, so that musb glue
> code build as module can use it.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/usb/musb/musb_virthub.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/musb/musb_virthub.c b/drivers/usb/musb/musb_virthub.c
> index fe08e77..61b5f1c 100644
> --- a/drivers/usb/musb/musb_virthub.c
> +++ b/drivers/usb/musb/musb_virthub.c
> @@ -245,6 +245,7 @@ void musb_root_disconnect(struct musb *musb)
> usb_otg_state_string(musb->xceiv->otg->state));
> }
> }
> +EXPORT_SYMBOL_GPL(musb_root_disconnect);
>
>
> /*---------------------------------------------------------------------*/
Does this fix a build error somehow? Who reported it?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] musb: Export musb_root_disconnect for use in modules
2016-09-16 15:47 ` Greg Kroah-Hartman
@ 2016-09-16 15:53 ` Mark Brown
2016-09-16 15:56 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2016-09-16 15:53 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote:
> > +EXPORT_SYMBOL_GPL(musb_root_disconnect);
> Does this fix a build error somehow? Who reported it?
Yes, the sunxi driver uses this symbol and the build bots reported it
yesterday.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160916/1c94a40d/attachment-0001.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] musb: Export musb_root_disconnect for use in modules
2016-09-16 15:53 ` Mark Brown
@ 2016-09-16 15:56 ` Greg Kroah-Hartman
2016-09-17 10:12 ` Hans de Goede
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-16 15:56 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 16, 2016 at 04:53:17PM +0100, Mark Brown wrote:
> On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote:
>
> > > +EXPORT_SYMBOL_GPL(musb_root_disconnect);
>
> > Does this fix a build error somehow? Who reported it?
>
> Yes, the sunxi driver uses this symbol and the build bots reported it
> yesterday.
then all of that should have been in this patch :(
So much for me trying to be subtle...
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] musb: Export musb_root_disconnect for use in modules
2016-09-16 15:56 ` Greg Kroah-Hartman
@ 2016-09-17 10:12 ` Hans de Goede
2016-09-17 10:43 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2016-09-17 10:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 16-09-16 17:56, Greg Kroah-Hartman wrote:
> On Fri, Sep 16, 2016 at 04:53:17PM +0100, Mark Brown wrote:
>> On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote:
>>> On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote:
>>
>>>> +EXPORT_SYMBOL_GPL(musb_root_disconnect);
>>
>>> Does this fix a build error somehow? Who reported it?
>>
>> Yes, the sunxi driver uses this symbol and the build bots reported it
>> yesterday.
>
> then all of that should have been in this patch :(
>
> So much for me trying to be subtle...
Sorry, you're right, I'll add a Fixes tag, and I'll mention
this fixes a buildbot reported error too.
I'll do a v2 with this right away.
For the next time, is there any official format to
mention the buildbot report or some such ?
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] musb: Export musb_root_disconnect for use in modules
2016-09-17 10:12 ` Hans de Goede
@ 2016-09-17 10:43 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-17 10:43 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Sep 17, 2016 at 12:12:04PM +0200, Hans de Goede wrote:
> Hi,
>
> On 16-09-16 17:56, Greg Kroah-Hartman wrote:
> > On Fri, Sep 16, 2016 at 04:53:17PM +0100, Mark Brown wrote:
> > > On Fri, Sep 16, 2016 at 05:47:01PM +0200, Greg Kroah-Hartman wrote:
> > > > On Fri, Sep 16, 2016 at 04:59:36PM +0200, Hans de Goede wrote:
> > >
> > > > > +EXPORT_SYMBOL_GPL(musb_root_disconnect);
> > >
> > > > Does this fix a build error somehow? Who reported it?
> > >
> > > Yes, the sunxi driver uses this symbol and the build bots reported it
> > > yesterday.
> >
> > then all of that should have been in this patch :(
> >
> > So much for me trying to be subtle...
>
> Sorry, you're right, I'll add a Fixes tag, and I'll mention
> this fixes a buildbot reported error too.
>
> I'll do a v2 with this right away.
>
> For the next time, is there any official format to
> mention the buildbot report or some such ?
like normal:
"Reported-by: ...."
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-17 10:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-16 14:59 [PATCH] musb: Export musb_root_disconnect for use in modules Hans de Goede
2016-09-16 15:47 ` Greg Kroah-Hartman
2016-09-16 15:53 ` Mark Brown
2016-09-16 15:56 ` Greg Kroah-Hartman
2016-09-17 10:12 ` Hans de Goede
2016-09-17 10:43 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).