From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] clk: let clk_disable() return immediately if clk is NULL
Date: Fri, 16 Sep 2016 16:11:25 -0700 [thread overview]
Message-ID: <20160916231125.GW7243@codeaurora.org> (raw)
In-Reply-To: <CAK7LNARaV6Ga5G1GnYf9hywrr+YwOqqm-v1AzBpfXtM4u9ofBA@mail.gmail.com>
On 09/16, Masahiro Yamada wrote:
> Hi Stephen, Michael,
>
> 2016-08-26 0:27 GMT+09:00 Florian Fainelli <f.fainelli@gmail.com>:
> > On 08/24/2016 10:26 AM, Masahiro Yamada wrote:
> >> Many of clk_disable() implementations just return for NULL pointer,
> >> but this check is missing from some. Let's make it tree-wide
> >> consistent. It will allow clock consumers to call clk_disable()
> >> without NULL pointer check.
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >> Acked-by: Greg Ungerer <gerg@uclinux.org>
> >> Acked-by: Wan Zongshun <mcuos.com@gmail.com>
> >> ---
> >>
> >> I came back after a long pause.
> >> You can see the discussion about the previous version:
> >> https://www.linux-mips.org/archives/linux-mips/2016-04/msg00063.html
> >>
> >>
> >> Changes in v3:
> >> - Return only when clk is NULL. Do not take care of error pointer.
> >>
> >> Changes in v2:
> >> - Rebase on Linux 4.6-rc1
> >>
> >> arch/arm/mach-mmp/clock.c | 3 +++
> >> arch/arm/mach-w90x900/clock.c | 3 +++
> >> arch/blackfin/mach-bf609/clock.c | 3 +++
> >> arch/m68k/coldfire/clk.c | 4 ++++
> >> arch/mips/bcm63xx/clk.c | 3 +++
> >
>
>
> Gentle ping...
>
>
> If you are not keen on this,
> shall I split it per-arch and send to each arch subsystem?
>
If we get acks from more arch maintainers we could take it
through clk tree, but we really don't maintain these other clk
implementations so it isn't very appropriate to take it through
clk tree anyway. Perhaps splitting it up per arch and sending it
that way and then Ccing akpm (aka the patch collector) would make
sure things get merged in a timely manner. Or Andrew could just
pick up this patch as is.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2016-09-16 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 17:26 [PATCH v3] clk: let clk_disable() return immediately if clk is NULL Masahiro Yamada
2016-08-25 7:52 ` Geert Uytterhoeven
2016-08-25 15:27 ` Florian Fainelli
2016-09-16 7:44 ` Masahiro Yamada
2016-09-16 23:11 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916231125.GW7243@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).