From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] tty: amba-pl011: define flag register bits for ZTE device
Date: Sat, 17 Sep 2016 13:37:53 +0800 [thread overview]
Message-ID: <20160917053753.GG7398@tiger> (raw)
In-Reply-To: <57DC27A9.3060307@codeaurora.org>
On Fri, Sep 16, 2016 at 12:11:05PM -0500, Timur Tabi wrote:
> Russell King - ARM Linux wrote:
> >Maybe what we should've done with ZTE is insisted that they implement
> >a complete new driver, rather than trying to shoe-horn it into PL011
> >even though it is in theory PL011.
>
> When I suggested that a year ago, I was shot down:
>
> http://www.spinics.net/lists/arm-kernel/msg455888.html
I still think that's a bad idea. ZTE is not the first one making such
small customization on PL011, and likely won't be the last one. We
don't want to clone PL011 driver every time there is a such vendor
hardware coming out, do we? Having PL011 driver being able to handle
different register layout is very helpful to handle such vendor
variants, IMHO.
I still appreciate rmk's insistence to handle ZTE device with PL011
driver, and the effort of adding a little "infrastructure" to handle
all such possible variants.
Shawn
next prev parent reply other threads:[~2016-09-17 5:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 9:00 [PATCH v3 0/3] Complete ZTE PL011 device support Shawn Guo
2016-07-08 9:00 ` [PATCH v3 1/3] tty: amba-pl011: define flag register bits for ZTE device Shawn Guo
2016-09-16 14:23 ` Sudeep Holla
2016-09-16 16:39 ` Russell King - ARM Linux
2016-09-16 17:11 ` Timur Tabi
2016-09-17 5:37 ` Shawn Guo [this message]
2016-09-17 9:17 ` Russell King - ARM Linux
2016-09-17 5:26 ` Shawn Guo
2016-07-08 9:00 ` [PATCH v3 2/3] tty: amba-pl011: add .get_fifosize " Shawn Guo
2016-07-08 9:00 ` [PATCH v3 3/3] tty: amba-pl011: probe ZTE device from AMBA bus with a pseudo-ID Shawn Guo
2016-07-14 13:26 ` [PATCH v3 0/3] Complete ZTE PL011 device support Shawn Guo
2016-07-18 13:35 ` Russell King - ARM Linux
2016-08-09 3:21 ` Shawn Guo
2016-08-09 8:27 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917053753.GG7398@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox