From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization
Date: Mon, 19 Sep 2016 20:06:27 +0200 [thread overview]
Message-ID: <20160919200627.3ca1aae4@bbrezillon> (raw)
In-Reply-To: <CAD=FV=UyW5cXGGmq5xUzZ1aV5NzbBYGOz1gO9V1itrFU-PigAw@mail.gmail.com>
On Mon, 19 Sep 2016 10:52:51 -0700
Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> On Mon, Sep 19, 2016 at 10:48 AM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> > The PWM chip has always claimed the pins and muxed them to the PWM IP.
> > So, this means it's broken from the beginning, and my patch is only
> > uncovering the problem (unless the pins stay configured as input until
> > the PWM is enabled, which I'm not sure is the case).
>
> Such a solution is achievable with the pinctrl APIs pretty easily.
> You might not be able to use the automatic "init" state but you can do
> something similar and switch to an "active" state once the PWM is
> actually turned on the first time.
But is it really the case here (I don't see any code requesting a
specific pinmux depending on the PWM state)?
Anyway, we really need to handle this case, we should define the
typical voltage when the PWM is disabled. Same as what you suggested
with voltage-when-input, but with a different naming (since the concept
of pinmux is PWM hardware/driver specific).
voltage-when-pwm-disabled = <...>;
next prev parent reply other threads:[~2016-09-19 18:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:43 [PATCH 0/1] fix rk3066a based boards boot issue on linux-4.8 Andy Yan
2016-09-19 8:44 ` [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization Andy Yan
2016-09-19 9:25 ` Boris Brezillon
2016-09-19 9:38 ` Andy Yan
2016-09-19 9:44 ` Boris Brezillon
2016-09-19 15:15 ` Doug Anderson
2016-09-19 16:15 ` Heiko Stuebner
2016-09-19 16:38 ` Doug Anderson
2016-09-19 17:13 ` Boris Brezillon
2016-09-19 17:22 ` Doug Anderson
2016-09-19 17:48 ` Boris Brezillon
2016-09-19 17:52 ` Doug Anderson
2016-09-19 18:06 ` Boris Brezillon [this message]
2016-09-19 18:12 ` Doug Anderson
2016-09-19 18:31 ` Boris Brezillon
2016-09-19 20:43 ` Boris Brezillon
2016-09-19 21:15 ` Doug Anderson
2016-09-22 15:12 ` Boris Brezillon
2016-09-22 16:47 ` Mark Brown
2016-09-22 18:13 ` Boris Brezillon
2016-09-22 19:26 ` Mark Brown
2016-09-19 17:25 ` Heiko Stuebner
2016-09-19 9:21 ` [PATCH 0/1] fix rk3066a based boards boot issue on linux-4.8 Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919200627.3ca1aae4@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).