From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: imx6: initialize GPU clocks
Date: Tue, 20 Sep 2016 21:00:19 +0800 [thread overview]
Message-ID: <20160920130018.GE3744@tiger> (raw)
In-Reply-To: <1474276031.31321.0.camel@pengutronix.de>
On Mon, Sep 19, 2016 at 11:07:11AM +0200, Lucas Stach wrote:
> > > diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
> > > index 64c243173395..751c3e7d5843 100644
> > > --- a/drivers/clk/imx/clk-imx6q.c
> > > +++ b/drivers/clk/imx/clk-imx6q.c
> > > @@ -633,6 +633,24 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
> > > if (IS_ENABLED(CONFIG_PCI_IMX6))
> > > clk_set_parent(clk[IMX6QDL_CLK_LVDS1_SEL], clk[IMX6QDL_CLK_SATA_REF_100M]);
> > >
> > > + /*
> > > + * Initialize the GPU clock muxes, so that the maximum specified clock
> > > + * rates for the respective SoC are not exceeded.
> > > + */
> > > + if (clk_on_imx6dl()) {
> > > + clk_set_parent(clk[IMX6QDL_CLK_GPU3D_CORE_SEL],
> > > + clk[IMX6QDL_CLK_PLL2_PFD1_594M]);
> > > + clk_set_parent(clk[IMX6QDL_CLK_GPU2D_CORE_SEL],
> > > + clk[IMX6QDL_CLK_PLL2_PFD1_594M]);
> > > + } else if (clk_on_imx6q()) {
> > > + clk_set_parent(clk[IMX6QDL_CLK_GPU3D_CORE_SEL],
> > > + clk[IMX6QDL_CLK_MMDC_CH0_AXI]);
> > > + clk_set_parent(clk[IMX6QDL_CLK_GPU3D_SHADER_SEL],
> > > + clk[IMX6QDL_CLK_PLL2_PFD1_594M]);
> > > + clk_set_parent(clk[IMX6QDL_CLK_GPU2D_CORE_SEL],
> > > + clk[IMX6QDL_CLK_PLL3_USB_OTG]);
> > > + }
> > > +
> >
> > Can we handle these with assigned-clock-parents from device tree?
> >
> No, we want to get rid of the GPU overclocking even with old DTs. DT
> stability rules and all that...
Fair point. For both patches,
Acked-by: Shawn Guo <shawnguo@kernel.org>
next prev parent reply other threads:[~2016-09-20 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 9:16 [PATCH 1/2] clk: imx6: fix i.MX6DL clock tree to reflect reality Lucas Stach
2016-09-16 9:16 ` [PATCH 2/2] clk: imx6: initialize GPU clocks Lucas Stach
2016-09-18 0:17 ` Shawn Guo
2016-09-19 9:07 ` Lucas Stach
2016-09-20 13:00 ` Shawn Guo [this message]
2016-09-20 23:58 ` Stephen Boyd
2016-09-18 0:14 ` [PATCH 1/2] clk: imx6: fix i.MX6DL clock tree to reflect reality Shawn Guo
2016-09-20 23:58 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920130018.GE3744@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).