From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/9] dmaengine: ti-dma-crossbar: Use enum for crossbar type
Date: Wed, 21 Sep 2016 09:22:26 +0530 [thread overview]
Message-ID: <20160921035226.GE2609@localhost> (raw)
In-Reply-To: <20160916083324.29133-9-peter.ujfalusi@ti.com>
On Fri, Sep 16, 2016 at 11:33:23AM +0300, Peter Ujfalusi wrote:
> Fixes compiler warning on 64bit architectures.
Would be good to give the warning message here
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/dma/ti-dma-crossbar.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/ti-dma-crossbar.c b/drivers/dma/ti-dma-crossbar.c
> index e4f3bd1ae264..876e4ccaf033 100644
> --- a/drivers/dma/ti-dma-crossbar.c
> +++ b/drivers/dma/ti-dma-crossbar.c
> @@ -16,8 +16,10 @@
> #include <linux/of_device.h>
> #include <linux/of_dma.h>
>
> -#define TI_XBAR_DRA7 0
> -#define TI_XBAR_AM335X 1
> +enum ti_xbar_type {
> + TI_XBAR_DRA7 = 0,
> + TI_XBAR_AM335X,
> +};
>
> static const struct of_device_id ti_dma_xbar_match[] = {
> {
> @@ -395,7 +397,7 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
>
> xbar->dmarouter.dev = &pdev->dev;
> xbar->dmarouter.route_free = ti_dra7_xbar_free;
> - xbar->dma_offset = (u32)match->data;
> + xbar->dma_offset = (enum ti_xbar_type)match->data;
>
> mutex_init(&xbar->mutex);
> platform_set_drvdata(pdev, xbar);
> @@ -428,7 +430,7 @@ static int ti_dma_xbar_probe(struct platform_device *pdev)
> if (unlikely(!match))
> return -EINVAL;
>
> - switch ((u32)match->data) {
> + switch ((enum ti_xbar_type)match->data) {
> case TI_XBAR_DRA7:
> ret = ti_dra7_xbar_probe(pdev);
> break;
> --
> 2.10.0
>
--
~Vinod
next prev parent reply other threads:[~2016-09-21 3:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 8:33 [PATCH 0/9] dmaengine: ti drivers: enable COMPILE_TESTing Peter Ujfalusi
2016-09-16 8:33 ` [PATCH 1/9] dmaengine: edma: Add missing MODULE_DEVICE_TABLE() for of_device_id structs Peter Ujfalusi
2016-09-16 8:33 ` [PATCH 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC) Peter Ujfalusi
2016-09-16 8:33 ` [PATCH 3/9] dmaengine: edma: Use correct type for of_find_property() third parameter Peter Ujfalusi
2016-09-16 8:33 ` [PATCH 4/9] dmaengine: edma: enable COMPILE_TEST Peter Ujfalusi
2016-09-16 8:33 ` [PATCH 5/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile test on non OMAP configs Peter Ujfalusi
2016-09-21 3:51 ` Vinod Koul
2016-09-21 3:53 ` Vinod Koul
2016-09-21 7:34 ` Peter Ujfalusi
2016-09-16 8:33 ` [PATCH 6/9] dmaengine: omap-dma: enable COMPILE_TEST Peter Ujfalusi
2016-09-16 8:33 ` [PATCH 7/9] dmaengine: ti-dma-crossbar: Correct type for of_find_property() third parameter Peter Ujfalusi
2016-09-16 8:33 ` [PATCH 8/9] dmaengine: ti-dma-crossbar: Use enum for crossbar type Peter Ujfalusi
2016-09-21 3:52 ` Vinod Koul [this message]
2016-09-21 7:31 ` Peter Ujfalusi
2016-09-16 8:33 ` [PATCH 9/9] dmaengine: ti-dma-crossbar: enable COMPILE_TEST Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921035226.GE2609@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).