linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: set path to Image.gz in the mkspec to avoid rpm build issue
@ 2016-09-27 15:53 Vadim Lomovtsev
  2016-09-28  9:49 ` Will Deacon
  0 siblings, 1 reply; 4+ messages in thread
From: Vadim Lomovtsev @ 2016-09-27 15:53 UTC (permalink / raw)
  To: linux-arm-kernel

In addition to http://www.spinics.net/lists/arm-kernel/msg527466.html

While building rpm-pkg target it fails to copy kernel image
from default location to rpm buildroot directory.

Since we have arch variable set to aarch64 while Image.gz
is located at arch/arm64/boot it's necessary to specify
correct path to cp command as it implemeted for ppc64 build.

Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
---
 scripts/package/mkspec | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/package/mkspec b/scripts/package/mkspec
index 57673ba..2f2bc7e 100755
--- a/scripts/package/mkspec
+++ b/scripts/package/mkspec
@@ -101,9 +101,13 @@ echo "%ifarch ppc64"
 echo "cp vmlinux arch/powerpc/boot"
 echo "cp arch/powerpc/boot/"'$KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/vmlinuz-$KERNELRELEASE"
 echo "%else"
+echo "%ifarch aarch64"
+echo "cp arch/arm64/boot/"'$KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/vmlinuz-$KERNELRELEASE"
+echo "%else"
 echo 'cp $KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/vmlinuz-$KERNELRELEASE"
 echo "%endif"
 echo "%endif"
+echo "%endif"
 
 echo 'make %{?_smp_mflags} INSTALL_HDR_PATH=$RPM_BUILD_ROOT/usr KBUILD_SRC= headers_install'
 echo 'cp System.map $RPM_BUILD_ROOT'"/boot/System.map-$KERNELRELEASE"
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] arm64: set path to Image.gz in the mkspec to avoid rpm build issue
  2016-09-27 15:53 [PATCH] arm64: set path to Image.gz in the mkspec to avoid rpm build issue Vadim Lomovtsev
@ 2016-09-28  9:49 ` Will Deacon
  2016-09-29  7:23   ` Michal Marek
  0 siblings, 1 reply; 4+ messages in thread
From: Will Deacon @ 2016-09-28  9:49 UTC (permalink / raw)
  To: linux-arm-kernel

[Adding Michal Marek]

On Tue, Sep 27, 2016 at 08:53:47AM -0700, Vadim Lomovtsev wrote:
> In addition to http://www.spinics.net/lists/arm-kernel/msg527466.html
> 
> While building rpm-pkg target it fails to copy kernel image
> from default location to rpm buildroot directory.
> 
> Since we have arch variable set to aarch64 while Image.gz
> is located at arch/arm64/boot it's necessary to specify
> correct path to cp command as it implemeted for ppc64 build.
> 
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
> ---
>  scripts/package/mkspec | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> index 57673ba..2f2bc7e 100755
> --- a/scripts/package/mkspec
> +++ b/scripts/package/mkspec
> @@ -101,9 +101,13 @@ echo "%ifarch ppc64"
>  echo "cp vmlinux arch/powerpc/boot"
>  echo "cp arch/powerpc/boot/"'$KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/vmlinuz-$KERNELRELEASE"
>  echo "%else"
> +echo "%ifarch aarch64"
> +echo "cp arch/arm64/boot/"'$KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/vmlinuz-$KERNELRELEASE"
> +echo "%else"
>  echo 'cp $KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/vmlinuz-$KERNELRELEASE"
>  echo "%endif"
>  echo "%endif"
> +echo "%endif"
>  
>  echo 'make %{?_smp_mflags} INSTALL_HDR_PATH=$RPM_BUILD_ROOT/usr KBUILD_SRC= headers_install'
>  echo 'cp System.map $RPM_BUILD_ROOT'"/boot/System.map-$KERNELRELEASE"
> -- 
> 1.8.3.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] arm64: set path to Image.gz in the mkspec to avoid rpm build issue
  2016-09-28  9:49 ` Will Deacon
@ 2016-09-29  7:23   ` Michal Marek
  2016-09-29  8:09     ` Vadim Lomovtsev
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Marek @ 2016-09-29  7:23 UTC (permalink / raw)
  To: linux-arm-kernel

On 2016-09-28 11:49, Will Deacon wrote:
> [Adding Michal Marek]
> 
> On Tue, Sep 27, 2016 at 08:53:47AM -0700, Vadim Lomovtsev wrote:
>> In addition to http://www.spinics.net/lists/arm-kernel/msg527466.html
>>
>> While building rpm-pkg target it fails to copy kernel image
>> from default location to rpm buildroot directory.
>>
>> Since we have arch variable set to aarch64 while Image.gz
>> is located at arch/arm64/boot it's necessary to specify
>> correct path to cp command as it implemeted for ppc64 build.

The variable should point to the actual file. ppc64 should be fixed as well.

Michal

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] arm64: set path to Image.gz in the mkspec to avoid rpm build issue
  2016-09-29  7:23   ` Michal Marek
@ 2016-09-29  8:09     ` Vadim Lomovtsev
  0 siblings, 0 replies; 4+ messages in thread
From: Vadim Lomovtsev @ 2016-09-29  8:09 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 29, 2016 at 09:23:51AM +0200, Michal Marek wrote:
> On 2016-09-28 11:49, Will Deacon wrote:
> > [Adding Michal Marek]
> > 
> > On Tue, Sep 27, 2016 at 08:53:47AM -0700, Vadim Lomovtsev wrote:
> >> In addition to http://www.spinics.net/lists/arm-kernel/msg527466.html
> >>
> >> While building rpm-pkg target it fails to copy kernel image
> >> from default location to rpm buildroot directory.
> >>
> >> Since we have arch variable set to aarch64 while Image.gz
> >> is located at arch/arm64/boot it's necessary to specify
> >> correct path to cp command as it implemeted for ppc64 build.
> 
> The variable should point to the actual file. ppc64 should be fixed as well.
> 
> Michal

Understood. Thanks for feed-back.

Vadim

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-29  8:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-27 15:53 [PATCH] arm64: set path to Image.gz in the mkspec to avoid rpm build issue Vadim Lomovtsev
2016-09-28  9:49 ` Will Deacon
2016-09-29  7:23   ` Michal Marek
2016-09-29  8:09     ` Vadim Lomovtsev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).