From: viro@ZenIV.linux.org.uk (Al Viro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative"
Date: Thu, 6 Oct 2016 23:00:51 +0100 [thread overview]
Message-ID: <20161006220050.GN19539@ZenIV.linux.org.uk> (raw)
In-Reply-To: <f6ba2bf7-4f0b-e874-d642-6620d5df2212@codeaurora.org>
On Thu, Oct 06, 2016 at 05:41:34PM -0400, Sinan Kaya wrote:
> On 10/6/2016 5:37 PM, Al Viro wrote:
> > On Thu, Oct 06, 2016 at 05:30:29PM -0400, Sinan Kaya wrote:
> >> This reverts commit acc29fb8f792 ("debugfs: ->d_parent is never NULL or
> >> negative") as it breaks the debugfs_remove_recursive API as show in the
> >> callstack below.
> >
> > NAK. Fix your code, don't break global asserts.
> >
>
> I can fix the code if you tell me what the problem is:
Getting dentries with NULL ->d_parent should never, ever happen. Find the
place where such a beast appears and you've got your problem.
The same goes for negative dentries with children. Again, if your code
triggers such a situation, find where it does so and you've found a bug.
More than one, at that.
next prev parent reply other threads:[~2016-10-06 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 21:30 [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Sinan Kaya
2016-10-06 21:37 ` Al Viro
2016-10-06 21:41 ` Sinan Kaya
2016-10-06 21:56 ` Sinan Kaya
2016-10-06 22:11 ` Sinan Kaya
2016-10-06 22:00 ` Al Viro [this message]
2016-10-06 22:37 ` Al Viro
2016-10-06 22:41 ` Al Viro
2016-10-06 23:21 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006220050.GN19539@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox