From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] serial: stm32: fix a type issue
Date: Wed, 12 Oct 2016 12:11:11 +0300 [thread overview]
Message-ID: <20161012091111.GC5687@mwanda> (raw)
In-Reply-To: <20161012085239.GD1041@n2100.armlinux.org.uk>
On Wed, Oct 12, 2016 at 09:52:39AM +0100, Russell King - ARM Linux wrote:
> On Wed, Oct 12, 2016 at 09:21:03AM +0300, Dan Carpenter wrote:
> > We store UNDEF_REG in a u8. It causes a problem in functions like
> > stm32_tx_dma_complete() where we check "if (ofs->icr == UNDEF_REG)".
> >
> > Fixes: 3489187204eb ('serial: stm32: adding dma support')
>
> Correct form is:
>
> Fixes: 12-digit-hash ("summary line")
When I originally created the Fixes tag format, I used single quotes.
I don't remember why though and I can change with the times. :)
regards,
dan carpenter
prev parent reply other threads:[~2016-10-12 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 6:21 [patch] serial: stm32: fix a type issue Dan Carpenter
2016-10-12 7:40 ` Gerald Baeza
2016-10-12 8:52 ` Russell King - ARM Linux
2016-10-12 9:11 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012091111.GC5687@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).