* [bug report] PCI: rockchip: Add Rockchip PCIe controller support
@ 2016-10-12 10:54 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-10-12 10:54 UTC (permalink / raw)
To: linux-arm-kernel
Hello Shawn Lin,
The patch e77f847df54c: "PCI: rockchip: Add Rockchip PCIe controller
support" from Sep 3, 2016, leads to the following static checker
warning:
drivers/pci/host/pcie-rockchip.c:552 rockchip_pcie_init_port()
warn: mask and shift to zero
drivers/pci/host/pcie-rockchip.c
549
550 /* Check the final link width from negotiated lane counter from MGMT */
551 status = rockchip_pcie_read(rockchip, PCIE_CORE_CTRL);
552 status = 0x1 << ((status & PCIE_CORE_PL_CONF_LANE_MASK) >>
553 PCIE_CORE_PL_CONF_LANE_MASK);
Presumably we should be shifting by PCIE_CORE_PL_CONF_LANE_SHIFT but
this still looks all kind of jumbled up.
554 dev_dbg(dev, "current link width is x%d\n", status);
555
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-10-12 10:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12 10:54 [bug report] PCI: rockchip: Add Rockchip PCIe controller support Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).