linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/5] Cavium ThunderX uncore PMU support
Date: Thu, 20 Oct 2016 11:41:54 +0100	[thread overview]
Message-ID: <20161020104146.GC10234@leverpostej> (raw)
In-Reply-To: <1476955841-27898-1-git-send-email-jglauber@cavium.com>

On Thu, Oct 20, 2016 at 11:30:36AM +0200, Jan Glauber wrote:
> Sorry for the long time it took for re-cooking this patch set.
> The v3 should address all of Marks previous comments, things I didn't
> change are listed below.
> 
> Not changed:
> - Stick to NUMA node ID to detect the socket a device belongs to but made
>   uncore depend on CONFIG_NUMA.
> - Stick to initcall for uncore framework because it is easier to do the
>   scanning for the same type of PCI devices, also I don't know if the PCI layer
>   would allow for several drivers to register for the same device ID.
> 
> Note:
> I'm using perf_sw_context in difference to perf_invalid_context
> (see WARN_ON in perf_pmu_register). Reason is that with perf_invalid_context
> add() is never called and the counter results are shown as "unsupported" by
> perf. With perf_sw_context everything works as expected.

I take it you were tryign to open per-task, non system-wide events?

As a shared resource, per-task events do not make sense, and thus using
perf_sw_context does not make sense.

I take it If you expose a cpumask, and open the event in system-wide
mode (passing '-a' to perf tool), things should work even if using
perf_invalid_context.

Thanks,
Mark.

      parent reply	other threads:[~2016-10-20 10:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20  9:30 [PATCH v3 0/5] Cavium ThunderX uncore PMU support Jan Glauber
2016-10-20  9:30 ` [PATCH v3 1/5] arm64: perf: Basic uncore counter support for Cavium ThunderX SOC Jan Glauber
2016-10-20  9:30 ` [PATCH v3 2/5] arm64: perf: Cavium ThunderX L2C TAD uncore support Jan Glauber
2016-10-20  9:30 ` [PATCH v3 3/5] arm64: perf: Cavium ThunderX L2C CBC " Jan Glauber
2016-10-20  9:30 ` [PATCH v3 4/5] arm64: perf: Cavium ThunderX LMC " Jan Glauber
2016-10-20  9:30 ` [PATCH v3 5/5] arm64: perf: Cavium ThunderX OCX TLK " Jan Glauber
2016-10-20 10:37 ` [PATCH v3 0/5] Cavium ThunderX uncore PMU support Peter Zijlstra
2016-10-20 10:44   ` Mark Rutland
2016-10-20 10:55     ` Peter Zijlstra
2016-10-20 11:01       ` Mark Rutland
2016-10-20 11:02   ` Jan Glauber
2016-10-20 11:23   ` Jan Glauber
2016-10-20 11:30     ` Peter Zijlstra
2016-10-28 15:17     ` Will Deacon
2016-10-28 15:36       ` Jan Glauber
2016-10-28 15:42         ` Mark Rutland
2016-10-20 10:41 ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161020104146.GC10234@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).