* [PATCH v2] ARM: at91/dt: fixes dbgu pinctrl, set pullup on rx, clear pullup on tx
@ 2016-10-16 16:21 Sylvain Rochet
2016-10-16 16:21 ` Sylvain Rochet
0 siblings, 1 reply; 6+ messages in thread
From: Sylvain Rochet @ 2016-10-16 16:21 UTC (permalink / raw)
To: linux-arm-kernel
Changes since v1:
* While we are at it, remove useless pinctrl comments, as suggested
by Alexandre.
* Remove consumption story about the pull-up on a push-pull output
in the commit message, it does not seem to be the case, or rather
the contrary, as per
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368643.html
results, the dt must be logical anyway.
Sylvain Rochet (1):
ARM: at91/dt: fixes dbgu pinctrl, set pullup on rx, clear pullup on tx
arch/arm/boot/dts/at91rm9200.dtsi | 4 ++--
arch/arm/boot/dts/at91sam9260.dtsi | 4 ++--
arch/arm/boot/dts/at91sam9261.dtsi | 4 ++--
arch/arm/boot/dts/at91sam9263.dtsi | 4 ++--
arch/arm/boot/dts/at91sam9g45.dtsi | 4 ++--
arch/arm/boot/dts/at91sam9n12.dtsi | 4 ++--
arch/arm/boot/dts/at91sam9rl.dtsi | 4 ++--
arch/arm/boot/dts/at91sam9x5.dtsi | 4 ++--
arch/arm/boot/dts/sama5d3.dtsi | 4 ++--
arch/arm/boot/dts/sama5d4.dtsi | 4 ++--
10 files changed, 20 insertions(+), 20 deletions(-)
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] ARM: at91/dt: fixes dbgu pinctrl, set pullup on rx, clear pullup on tx 2016-10-16 16:21 [PATCH v2] ARM: at91/dt: fixes dbgu pinctrl, set pullup on rx, clear pullup on tx Sylvain Rochet @ 2016-10-16 16:21 ` Sylvain Rochet 2016-10-20 15:35 ` Alexandre Belloni 0 siblings, 1 reply; 6+ messages in thread From: Sylvain Rochet @ 2016-10-16 16:21 UTC (permalink / raw) To: linux-arm-kernel Remove pullup on dbgu DTXD signal, it is a push-pull output thus the pullup is pointless. Add pullup on dbgu DRXD signal, it prevents the DRXD signal to be left floating and so consuming a useless extra amount of power in crowbarred state if nothing is externally connected to dbgu. Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com> --- arch/arm/boot/dts/at91rm9200.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9260.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9261.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9263.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9g45.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9n12.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9rl.dtsi | 4 ++-- arch/arm/boot/dts/at91sam9x5.dtsi | 4 ++-- arch/arm/boot/dts/sama5d3.dtsi | 4 ++-- arch/arm/boot/dts/sama5d4.dtsi | 4 ++-- 10 files changed, 20 insertions(+), 20 deletions(-) diff --git a/arch/arm/boot/dts/at91rm9200.dtsi b/arch/arm/boot/dts/at91rm9200.dtsi index 4e913c2..f057e0b 100644 --- a/arch/arm/boot/dts/at91rm9200.dtsi +++ b/arch/arm/boot/dts/at91rm9200.dtsi @@ -481,8 +481,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOA 30 AT91_PERIPH_A AT91_PINCTRL_NONE /* PA30 periph A */ - AT91_PIOA 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PA31 periph with pullup */ + <AT91_PIOA 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP + AT91_PIOA 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi index a3e363d..9e035b2 100644 --- a/arch/arm/boot/dts/at91sam9260.dtsi +++ b/arch/arm/boot/dts/at91sam9260.dtsi @@ -412,8 +412,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOB 14 AT91_PERIPH_A AT91_PINCTRL_NONE /* PB14 periph A */ - AT91_PIOB 15 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PB15 periph with pullup */ + <AT91_PIOB 14 AT91_PERIPH_A AT91_PINCTRL_PULL_UP + AT91_PIOB 15 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi index 32752d7..3fe77c3 100644 --- a/arch/arm/boot/dts/at91sam9261.dtsi +++ b/arch/arm/boot/dts/at91sam9261.dtsi @@ -302,8 +302,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOA 9 AT91_PERIPH_A AT91_PINCTRL_NONE>, - <AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; + <AT91_PIOA 9 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, + <AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi index aeb1a36..a1888f6 100644 --- a/arch/arm/boot/dts/at91sam9263.dtsi +++ b/arch/arm/boot/dts/at91sam9263.dtsi @@ -412,8 +412,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_NONE /* PC30 periph A */ - AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PC31 periph with pullup */ + <AT91_PIOC 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP + AT91_PIOC 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi index b3501ae..e567d5f 100644 --- a/arch/arm/boot/dts/at91sam9g45.dtsi +++ b/arch/arm/boot/dts/at91sam9g45.dtsi @@ -478,8 +478,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOB 12 AT91_PERIPH_A AT91_PINCTRL_NONE /* PB12 periph A */ - AT91_PIOB 13 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PB13 periph A */ + <AT91_PIOB 12 AT91_PERIPH_A AT91_PINCTRL_PULL_UP + AT91_PIOB 13 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; diff --git a/arch/arm/boot/dts/at91sam9n12.dtsi b/arch/arm/boot/dts/at91sam9n12.dtsi index 3b3eb3e..f43d769 100644 --- a/arch/arm/boot/dts/at91sam9n12.dtsi +++ b/arch/arm/boot/dts/at91sam9n12.dtsi @@ -500,8 +500,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOA 9 AT91_PERIPH_A AT91_PINCTRL_NONE /* PA9 periph A */ - AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PA10 periph with pullup */ + <AT91_PIOA 9 AT91_PERIPH_A AT91_PINCTRL_PULL_UP + AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; diff --git a/arch/arm/boot/dts/at91sam9rl.dtsi b/arch/arm/boot/dts/at91sam9rl.dtsi index 70adf94..f4c129a 100644 --- a/arch/arm/boot/dts/at91sam9rl.dtsi +++ b/arch/arm/boot/dts/at91sam9rl.dtsi @@ -438,8 +438,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOA 21 AT91_PERIPH_A AT91_PINCTRL_NONE>, - <AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; + <AT91_PIOA 21 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, + <AT91_PIOA 22 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index ed4e4bd..f66bae9 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts/at91sam9x5.dtsi @@ -460,8 +460,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOA 9 AT91_PERIPH_A AT91_PINCTRL_NONE /* PA9 periph A */ - AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PA10 periph A with pullup */ + <AT91_PIOA 9 AT91_PERIPH_A AT91_PINCTRL_PULL_UP + AT91_PIOA 10 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi index 4c84d33..b06448b 100644 --- a/arch/arm/boot/dts/sama5d3.dtsi +++ b/arch/arm/boot/dts/sama5d3.dtsi @@ -549,8 +549,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_NONE /* PB30 periph A */ - AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* PB31 periph A with pullup */ + <AT91_PIOB 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP + AT91_PIOB 31 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi index 65e725f..d136ebd 100644 --- a/arch/arm/boot/dts/sama5d4.dtsi +++ b/arch/arm/boot/dts/sama5d4.dtsi @@ -1461,8 +1461,8 @@ dbgu { pinctrl_dbgu: dbgu-0 { atmel,pins = - <AT91_PIOB 24 AT91_PERIPH_A AT91_PINCTRL_NONE>, /* conflicts with D14 and TDI */ - <AT91_PIOB 25 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; /* conflicts with D15 and TDO */ + <AT91_PIOB 24 AT91_PERIPH_A AT91_PINCTRL_PULL_UP + AT91_PIOB 25 AT91_PERIPH_A AT91_PINCTRL_NONE>; }; }; -- 2.9.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: at91/dt: fixes dbgu pinctrl, set pullup on rx, clear pullup on tx 2016-10-16 16:21 ` Sylvain Rochet @ 2016-10-20 15:35 ` Alexandre Belloni 2016-11-09 23:41 ` Peter Rosin 0 siblings, 1 reply; 6+ messages in thread From: Alexandre Belloni @ 2016-10-20 15:35 UTC (permalink / raw) To: linux-arm-kernel On 16/10/2016 at 18:21:45 +0200, Sylvain Rochet wrote : > Remove pullup on dbgu DTXD signal, it is a push-pull output thus the > pullup is pointless. > > Add pullup on dbgu DRXD signal, it prevents the DRXD signal to be left > floating and so consuming a useless extra amount of power in crowbarred > state if nothing is externally connected to dbgu. > > Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com> > --- > arch/arm/boot/dts/at91rm9200.dtsi | 4 ++-- > arch/arm/boot/dts/at91sam9260.dtsi | 4 ++-- > arch/arm/boot/dts/at91sam9261.dtsi | 4 ++-- > arch/arm/boot/dts/at91sam9263.dtsi | 4 ++-- > arch/arm/boot/dts/at91sam9g45.dtsi | 4 ++-- > arch/arm/boot/dts/at91sam9n12.dtsi | 4 ++-- > arch/arm/boot/dts/at91sam9rl.dtsi | 4 ++-- > arch/arm/boot/dts/at91sam9x5.dtsi | 4 ++-- > arch/arm/boot/dts/sama5d3.dtsi | 4 ++-- > arch/arm/boot/dts/sama5d4.dtsi | 4 ++-- > 10 files changed, 20 insertions(+), 20 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: at91/dt: fixes dbgu pinctrl, set pullup on rx, clear pullup on tx 2016-10-20 15:35 ` Alexandre Belloni @ 2016-11-09 23:41 ` Peter Rosin 2016-11-10 0:09 ` Alexandre Belloni 0 siblings, 1 reply; 6+ messages in thread From: Peter Rosin @ 2016-11-09 23:41 UTC (permalink / raw) To: linux-arm-kernel On 2016-10-20 15:35, Alexandre Belloni wrote > On 16/10/2016 at 18:21:45 +0200, Sylvain Rochet wrote : >> Remove pullup on dbgu DTXD signal, it is a push-pull output thus the >> pullup is pointless. >> >> Add pullup on dbgu DRXD signal, it prevents the DRXD signal to be left >> floating and so consuming a useless extra amount of power in crowbarred >> state if nothing is externally connected to dbgu. >> >> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com> >> --- >> arch/arm/boot/dts/at91rm9200.dtsi | 4 ++-- >> arch/arm/boot/dts/at91sam9260.dtsi | 4 ++-- >> arch/arm/boot/dts/at91sam9261.dtsi | 4 ++-- >> arch/arm/boot/dts/at91sam9263.dtsi | 4 ++-- >> arch/arm/boot/dts/at91sam9g45.dtsi | 4 ++-- >> arch/arm/boot/dts/at91sam9n12.dtsi | 4 ++-- >> arch/arm/boot/dts/at91sam9rl.dtsi | 4 ++-- >> arch/arm/boot/dts/at91sam9x5.dtsi | 4 ++-- >> arch/arm/boot/dts/sama5d3.dtsi | 4 ++-- >> arch/arm/boot/dts/sama5d4.dtsi | 4 ++-- >> 10 files changed, 20 insertions(+), 20 deletions(-) >> > Applied, thanks. I can't seem to find this patch in any of the repos I'm looking at, so I'm wondering where it was applied and when it might hit mainline? Cheers, Peter ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: at91/dt: fixes dbgu pinctrl, set pullup on rx, clear pullup on tx 2016-11-09 23:41 ` Peter Rosin @ 2016-11-10 0:09 ` Alexandre Belloni 2016-11-10 8:04 ` Peter Rosin 0 siblings, 1 reply; 6+ messages in thread From: Alexandre Belloni @ 2016-11-10 0:09 UTC (permalink / raw) To: linux-arm-kernel On 10/11/2016 at 00:41:37 +0100, Peter Rosin wrote : > On 2016-10-20 15:35, Alexandre Belloni wrote > > On 16/10/2016 at 18:21:45 +0200, Sylvain Rochet wrote : > >> Remove pullup on dbgu DTXD signal, it is a push-pull output thus the > >> pullup is pointless. > >> > >> Add pullup on dbgu DRXD signal, it prevents the DRXD signal to be left > >> floating and so consuming a useless extra amount of power in crowbarred > >> state if nothing is externally connected to dbgu. > >> > >> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com> > >> --- > >> arch/arm/boot/dts/at91rm9200.dtsi | 4 ++-- > >> arch/arm/boot/dts/at91sam9260.dtsi | 4 ++-- > >> arch/arm/boot/dts/at91sam9261.dtsi | 4 ++-- > >> arch/arm/boot/dts/at91sam9263.dtsi | 4 ++-- > >> arch/arm/boot/dts/at91sam9g45.dtsi | 4 ++-- > >> arch/arm/boot/dts/at91sam9n12.dtsi | 4 ++-- > >> arch/arm/boot/dts/at91sam9rl.dtsi | 4 ++-- > >> arch/arm/boot/dts/at91sam9x5.dtsi | 4 ++-- > >> arch/arm/boot/dts/sama5d3.dtsi | 4 ++-- > >> arch/arm/boot/dts/sama5d4.dtsi | 4 ++-- > >> 10 files changed, 20 insertions(+), 20 deletions(-) > >> > > Applied, thanks. > > I can't seem to find this patch in any of the repos I'm looking at, > so I'm wondering where it was applied and when it might hit mainline? > It is applied there: http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/log/?h=at91-dt It will land in 4.10. I'll do the PR to arm-soc soon. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: at91/dt: fixes dbgu pinctrl, set pullup on rx, clear pullup on tx 2016-11-10 0:09 ` Alexandre Belloni @ 2016-11-10 8:04 ` Peter Rosin 0 siblings, 0 replies; 6+ messages in thread From: Peter Rosin @ 2016-11-10 8:04 UTC (permalink / raw) To: linux-arm-kernel On 2016-11-10 01:09, Alexandre Belloni wrote: > On 10/11/2016 at 00:41:37 +0100, Peter Rosin wrote : >> On 2016-10-20 15:35, Alexandre Belloni wrote >>> On 16/10/2016 at 18:21:45 +0200, Sylvain Rochet wrote : >>>> Remove pullup on dbgu DTXD signal, it is a push-pull output thus the >>>> pullup is pointless. >>>> >>>> Add pullup on dbgu DRXD signal, it prevents the DRXD signal to be left >>>> floating and so consuming a useless extra amount of power in crowbarred >>>> state if nothing is externally connected to dbgu. >>> Applied, thanks. >> >> I can't seem to find this patch in any of the repos I'm looking at, >> so I'm wondering where it was applied and when it might hit mainline? >> > > It is applied there: > http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/log/?h=at91-dt > > It will land in 4.10. I'll do the PR to arm-soc soon. Great, thanks! (expected it to be in -next by now and got worried, and couldn't find it in https://github.com/linux4sam/linux-at91 either...) Cheers, Peter ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-10 8:04 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-10-16 16:21 [PATCH v2] ARM: at91/dt: fixes dbgu pinctrl, set pullup on rx, clear pullup on tx Sylvain Rochet 2016-10-16 16:21 ` Sylvain Rochet 2016-10-20 15:35 ` Alexandre Belloni 2016-11-09 23:41 ` Peter Rosin 2016-11-10 0:09 ` Alexandre Belloni 2016-11-10 8:04 ` Peter Rosin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).