* [PATCH] ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031
@ 2016-10-24 12:32 Fabio Estevam
2016-10-24 13:14 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2016-10-24 12:32 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
AR8031 and AR8035 have the same PHY ID mask of 0xffffffef.
So fix it and make it match with the PHY ID mask definition
at drivers/net/phy/at803x.c.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/mach-imx/mach-imx6q.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
index 97fd251..45801b2 100644
--- a/arch/arm/mach-imx/mach-imx6q.c
+++ b/arch/arm/mach-imx/mach-imx6q.c
@@ -173,7 +173,7 @@ static void __init imx6q_enet_phy_init(void)
ksz9021rn_phy_fixup);
phy_register_fixup_for_uid(PHY_ID_KSZ9031, MICREL_PHY_ID_MASK,
ksz9031rn_phy_fixup);
- phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffff,
+ phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffef,
ar8031_phy_fixup);
phy_register_fixup_for_uid(PHY_ID_AR8035, 0xffffffef,
ar8035_phy_fixup);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031
2016-10-24 12:32 [PATCH] ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031 Fabio Estevam
@ 2016-10-24 13:14 ` Shawn Guo
2016-10-24 13:17 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2016-10-24 13:14 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 24, 2016 at 10:32:12AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> AR8031 and AR8035 have the same PHY ID mask of 0xffffffef.
>
> So fix it and make it match with the PHY ID mask definition
> at drivers/net/phy/at803x.c.
It was working well with a wrong ID?
Shawn
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/mach-imx/mach-imx6q.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 97fd251..45801b2 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -173,7 +173,7 @@ static void __init imx6q_enet_phy_init(void)
> ksz9021rn_phy_fixup);
> phy_register_fixup_for_uid(PHY_ID_KSZ9031, MICREL_PHY_ID_MASK,
> ksz9031rn_phy_fixup);
> - phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffff,
> + phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffef,
> ar8031_phy_fixup);
> phy_register_fixup_for_uid(PHY_ID_AR8035, 0xffffffef,
> ar8035_phy_fixup);
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031
2016-10-24 13:14 ` Shawn Guo
@ 2016-10-24 13:17 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-10-24 13:17 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 24, 2016 at 11:14 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Mon, Oct 24, 2016 at 10:32:12AM -0200, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> AR8031 and AR8035 have the same PHY ID mask of 0xffffffef.
>>
>> So fix it and make it match with the PHY ID mask definition
>> at drivers/net/phy/at803x.c.
>
> It was working well with a wrong ID?
Yes, it was working well even with the wrong PHY ID mask.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-24 13:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-24 12:32 [PATCH] ARM: imx: mach-imx6q: Fix the PHY ID mask for AR8031 Fabio Estevam
2016-10-24 13:14 ` Shawn Guo
2016-10-24 13:17 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).