public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/7] drm: sunxi: add DE2 HDMI support
Date: Mon, 24 Oct 2016 15:17:03 +0200	[thread overview]
Message-ID: <20161024131703.exrqt5cqrepwuvkp@lukather> (raw)
In-Reply-To: <36bd5454897c8ab77749e0294e4a4ecc2450dd12.1477142934.git.moinejf@free.fr>

Hi,

On Fri, Oct 21, 2016 at 10:08:06AM +0200, Jean-Francois Moine wrote:
> This patch adds a HDMI driver to the DE2 based Allwinner's SoCs
> as A83T and H3.
> Audio and video are supported.
> 
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>

Output from checkpatch:
total: 26 errors, 31 warnings, 70 checks, 1458 lines checked

Please run checkpatch before sending your patches.

Apart from that, this looks an awful lot like the designware HDMI
controller, for which a driver already exists. Any reason to create a
new driver from scratch?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161024/aa53ff74/attachment-0001.sig>

  reply	other threads:[~2016-10-24 13:17 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-22 13:28 [PATCH v5 0/7] ARM: ASoC: drm: sun8i: Add DE2 HDMI audio and video Jean-Francois Moine
2016-10-21  7:26 ` [PATCH v5 1/7] drm: sunxi: Add a basic DRM driver for Allwinner DE2 Jean-Francois Moine
2016-10-24 14:04   ` Maxime Ripard
2016-10-25 14:14     ` Jean-Francois Moine
2016-10-25 23:52       ` [linux-sunxi] " André Przywara
2016-10-27 22:03       ` Maxime Ripard
2016-10-28 17:34         ` Jean-Francois Moine
2016-11-07 22:37           ` Maxime Ripard
2016-11-08 14:37             ` Jean-Francois Moine
2016-11-16 21:33               ` Maxime Ripard
2016-11-17 14:57                 ` Jean-Francois Moine
2016-10-30 20:41       ` Rob Herring
2016-10-25  6:44   ` Daniel Vetter
2016-10-25  6:46     ` Daniel Vetter
2016-10-25 14:16     ` Jean-Francois Moine
2016-10-30 20:41   ` Rob Herring
2016-10-21  7:44 ` [PATCH v5 2/7] ASoC: sunxi: Add a simple HDMI CODEC Jean-Francois Moine
2016-10-27 16:54   ` [linux-sunxi] " Chen-Yu Tsai
2016-10-27 17:16     ` Jean-Francois Moine
2016-10-27 18:36       ` Mark Brown
2016-10-21  8:08 ` [PATCH v5 3/7] drm: sunxi: add DE2 HDMI support Jean-Francois Moine
2016-10-24 13:17   ` Maxime Ripard [this message]
2016-10-30 20:41   ` Rob Herring
2016-10-21  8:36 ` [PATCH v5 4/7] ASoC: sunxi: Add sun8i I2S driver Jean-Francois Moine
2016-10-23  1:33   ` [linux-sunxi] " Chen-Yu Tsai
2016-10-23  7:45     ` Jean-Francois Moine
2016-10-24 12:34       ` Maxime Ripard
2016-10-27 15:13         ` [alsa-devel] " Jean-Francois Moine
2016-10-27 20:01           ` Maxime Ripard
2016-11-06 18:02     ` Jean-Francois Moine
2016-11-07 20:05       ` Maxime Ripard
2016-11-08 10:51         ` Jean-Francois Moine
2016-11-14 21:22           ` Maxime Ripard
2016-10-21 10:01 ` [PATCH v5 5/7] ARM: dts: sun8i-h3: add HDMI audio and video nodes Jean-Francois Moine
2016-10-22 10:29 ` [PATCH v5 6/7] ARM: dts: sun8i-h3: Add HDMI audio and video to the Banana Pi M2+ Jean-Francois Moine
2016-10-22 11:06 ` [PATCH v5 7/7] ARM: dts: sun8i-h3: Add HDMI audio and video to the Orange PI 2 Jean-Francois Moine
2016-10-23  1:38 ` [linux-sunxi] [PATCH v5 0/7] ARM: ASoC: drm: sun8i: Add DE2 HDMI audio and video Chen-Yu Tsai
2016-10-23  7:35   ` Jean-Francois Moine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161024131703.exrqt5cqrepwuvkp@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox