* [PATCH 0/4] i2c: Fix module autoload for some i2c busses platform drivers @ 2016-10-18 21:01 Javier Martinez Canillas 2016-10-18 21:01 ` [PATCH 4/4] i2c: digicolor: Fix module autoload Javier Martinez Canillas 2016-10-25 9:32 ` [PATCH 0/4] i2c: Fix module autoload for some i2c busses platform drivers Wolfram Sang 0 siblings, 2 replies; 4+ messages in thread From: Javier Martinez Canillas @ 2016-10-18 21:01 UTC (permalink / raw) To: linux-arm-kernel Hello Wolfram, I noticed that module autoload won't be working in some of the i2c busses drivers. This patch series contains the fixes for these. Best regards, Javier Javier Martinez Canillas (4): i2c: jz4780: Fix module autoload i2c: xlp9xx: Fix module autoload i2c: xlr: Fix module autoload for OF registration i2c: digicolor: Fix module autoload drivers/i2c/busses/i2c-digicolor.c | 1 + drivers/i2c/busses/i2c-jz4780.c | 1 + drivers/i2c/busses/i2c-xlp9xx.c | 1 + drivers/i2c/busses/i2c-xlr.c | 1 + 4 files changed, 4 insertions(+) -- 2.7.4 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 4/4] i2c: digicolor: Fix module autoload 2016-10-18 21:01 [PATCH 0/4] i2c: Fix module autoload for some i2c busses platform drivers Javier Martinez Canillas @ 2016-10-18 21:01 ` Javier Martinez Canillas 2016-10-19 5:05 ` Baruch Siach 2016-10-25 9:32 ` [PATCH 0/4] i2c: Fix module autoload for some i2c busses platform drivers Wolfram Sang 1 sibling, 1 reply; 4+ messages in thread From: Javier Martinez Canillas @ 2016-10-18 21:01 UTC (permalink / raw) To: linux-arm-kernel If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias $ After this patch: $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias alias: of:N*T*Ccnxt,cx92755-i2cC* alias: of:N*T*Ccnxt,cx92755-i2c Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/i2c/busses/i2c-digicolor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c index 9604024e0eb0..49f2084f7bb5 100644 --- a/drivers/i2c/busses/i2c-digicolor.c +++ b/drivers/i2c/busses/i2c-digicolor.c @@ -368,6 +368,7 @@ static const struct of_device_id dc_i2c_match[] = { { .compatible = "cnxt,cx92755-i2c" }, { }, }; +MODULE_DEVICE_TABLE(of, dc_i2c_match); static struct platform_driver dc_i2c_driver = { .probe = dc_i2c_probe, -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 4/4] i2c: digicolor: Fix module autoload 2016-10-18 21:01 ` [PATCH 4/4] i2c: digicolor: Fix module autoload Javier Martinez Canillas @ 2016-10-19 5:05 ` Baruch Siach 0 siblings, 0 replies; 4+ messages in thread From: Baruch Siach @ 2016-10-19 5:05 UTC (permalink / raw) To: linux-arm-kernel Hi Javier Martinez Canillas, On Tue, Oct 18, 2016 at 06:01:48PM -0300, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias > $ > > After this patch: > > $ modinfo drivers/i2c/busses/i2c-digicolor.ko | grep alias > alias: of:N*T*Ccnxt,cx92755-i2cC* > alias: of:N*T*Ccnxt,cx92755-i2c > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Acked-by: Baruch Siach <baruch@tkos.co.il> Thanks, baruch > drivers/i2c/busses/i2c-digicolor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c > index 9604024e0eb0..49f2084f7bb5 100644 > --- a/drivers/i2c/busses/i2c-digicolor.c > +++ b/drivers/i2c/busses/i2c-digicolor.c > @@ -368,6 +368,7 @@ static const struct of_device_id dc_i2c_match[] = { > { .compatible = "cnxt,cx92755-i2c" }, > { }, > }; > +MODULE_DEVICE_TABLE(of, dc_i2c_match); > > static struct platform_driver dc_i2c_driver = { > .probe = dc_i2c_probe, -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 0/4] i2c: Fix module autoload for some i2c busses platform drivers 2016-10-18 21:01 [PATCH 0/4] i2c: Fix module autoload for some i2c busses platform drivers Javier Martinez Canillas 2016-10-18 21:01 ` [PATCH 4/4] i2c: digicolor: Fix module autoload Javier Martinez Canillas @ 2016-10-25 9:32 ` Wolfram Sang 1 sibling, 0 replies; 4+ messages in thread From: Wolfram Sang @ 2016-10-25 9:32 UTC (permalink / raw) To: linux-arm-kernel On Tue, Oct 18, 2016 at 06:01:44PM -0300, Javier Martinez Canillas wrote: > Hello Wolfram, > > I noticed that module autoload won't be working in some of the i2c > busses drivers. This patch series contains the fixes for these. > > Best regards, > Javier Applied to for-current, thank you very much for doing this subsystem-wide! -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161025/a53437d0/attachment.sig> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-25 9:32 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-10-18 21:01 [PATCH 0/4] i2c: Fix module autoload for some i2c busses platform drivers Javier Martinez Canillas 2016-10-18 21:01 ` [PATCH 4/4] i2c: digicolor: Fix module autoload Javier Martinez Canillas 2016-10-19 5:05 ` Baruch Siach 2016-10-25 9:32 ` [PATCH 0/4] i2c: Fix module autoload for some i2c busses platform drivers Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox