From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 26 Oct 2016 13:17:30 +0100 Subject: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address In-Reply-To: References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-2-mugunthanvnm@ti.com> <20160927194045.GK21388@dell> Message-ID: <20161026121730.GS8574@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 30 Sep 2016, Mugunthan V N wrote: > On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote: > > On Wed, 21 Sep 2016, Mugunthan V N wrote: > > > >> store the physical address of the device in its priv to use it > >> for DMA addressing in the client drivers. > >> > >> Signed-off-by: Mugunthan V N > >> --- > >> drivers/mfd/ti_am335x_tscadc.c | 1 + > >> include/linux/mfd/ti_am335x_tscadc.h | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > >> index c8f027b..0f3fab4 100644 > >> --- a/drivers/mfd/ti_am335x_tscadc.c > >> +++ b/drivers/mfd/ti_am335x_tscadc.c > >> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) > >> tscadc->irq = err; > >> > >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + tscadc->tscadc_phys_base = res->start; > > > > This is unusual. Can't you use a virt_to_phys() variant instead? > > > > I tried using virt_to_phys(), but its not working for me. > Also saw many drivers uses like this to get physical address > ("git grep -n " res->start;" drivers/*"). Very well: For my own reference: Acked-for-MFD-by: Lee Jones Let me know how you wish this set to be handled. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog