From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] ARM: OMAP5: Enable minimal cpuidle for omap5 retention
Date: Wed, 26 Oct 2016 08:17:03 -0700 [thread overview]
Message-ID: <20161026151703.24730-6-tony@atomide.com> (raw)
In-Reply-To: <20161026151703.24730-1-tony@atomide.com>
This allows the CPUs to enter retention during idle and takes the idle
power consumption down quite a bit. On omap5-uevm, the power consumption
eventually settles down to about 920mW with ehci-omap and ohci-omap3
unloaded compared to about 1.7W without these patches. Note that it
seems to take few minutes after booting for the idle power to go down
to 920mW from 1.3W, no idea so far what might be causing that.
Note that the TI kernel supports more modes in the v3.8 kernel, but
the omap5 specific states can be added later.
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/cpuidle44xx.c | 2 +-
arch/arm/mach-omap2/pm44xx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c
--- a/arch/arm/mach-omap2/cpuidle44xx.c
+++ b/arch/arm/mach-omap2/cpuidle44xx.c
@@ -300,7 +300,7 @@ int __init omap4_idle_init(void)
{
struct cpuidle_driver *idle_driver;
- if (soc_is_dra7xx()) {
+ if (soc_is_dra7xx() || soc_is_omap54xx()) {
state_ptr = &dra7_idle_data[0];
idle_driver = &dra7_idle_driver;
} else {
diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
--- a/arch/arm/mach-omap2/pm44xx.c
+++ b/arch/arm/mach-omap2/pm44xx.c
@@ -287,7 +287,7 @@ int __init omap4_pm_init(void)
/* Overwrite the default cpu_do_idle() */
arm_pm_idle = omap_default_idle;
- if (cpu_is_omap44xx() || soc_is_dra7xx())
+ if (cpu_is_omap44xx() || soc_is_omap54xx() || soc_is_dra7xx())
omap4_idle_init();
err2:
--
2.9.3
next prev parent reply other threads:[~2016-10-26 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 15:16 [PATCH 0/5] Minimal cpuidle fixes for omap5 and dra7 Tony Lindgren
2016-10-26 15:16 ` [PATCH 1/5] ARM: OMAP5: Fix build for PM code Tony Lindgren
2016-10-26 15:17 ` [PATCH 2/5] ARM: OMAP5: Fix mpuss_early_init Tony Lindgren
2016-10-26 20:21 ` Tony Lindgren
2016-10-26 15:17 ` [PATCH 3/5] ARM: OMAP4+: Fix bad fallthrough for cpuidle Tony Lindgren
2016-10-26 15:17 ` [PATCH 4/5] ARM: DRA7: PM: cpuidle MPU CSWR support Tony Lindgren
2016-10-27 16:15 ` Tony Lindgren
2016-10-26 15:17 ` Tony Lindgren [this message]
2016-10-26 19:53 ` [PATCH 0/5] Minimal cpuidle fixes for omap5 and dra7 Santosh Shilimkar
2016-10-26 20:56 ` Nishanth Menon
2016-10-26 21:31 ` Tony Lindgren
2016-10-27 7:43 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026151703.24730-6-tony@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).