From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/sun4i: Add a few formats
Date: Thu, 27 Oct 2016 16:35:05 +0200 [thread overview]
Message-ID: <20161027143505.rblgbz5uqjynrtjk@lukather> (raw)
In-Reply-To: <CAGb2v65=6YGaaC3QimPHyP=FKJofygReozmnKLV8CGXvjWGtvQ@mail.gmail.com>
Hi,
On Tue, Oct 25, 2016 at 08:42:26AM +0800, Chen-Yu Tsai wrote:
> On Mon, Oct 24, 2016 at 10:40 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > On Fri, Oct 21, 2016 at 11:15:32AM +0800, Chen-Yu Tsai wrote:
> >> On Tue, Oct 18, 2016 at 4:46 PM, Maxime Ripard
> >> <maxime.ripard@free-electrons.com> wrote:
> >> > The planes can do more than what was previously exposed. Add support for
> >> > them.
> >> >
> >> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> >> > ---
> >> > drivers/gpu/drm/sun4i/sun4i_backend.c | 20 ++++++++++++++++++++
> >> > drivers/gpu/drm/sun4i/sun4i_layer.c | 6 ++++++
> >> > 2 files changed, 26 insertions(+)
> >> >
> >> > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
> >> > index afb7ddf660ef..b184a476a480 100644
> >> > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c
> >> > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
> >> > @@ -96,6 +96,22 @@ static int sun4i_backend_drm_format_to_layer(struct drm_plane *plane,
> >> > *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB8888;
> >> > break;
> >> >
> >> > + case DRM_FORMAT_ARGB4444:
> >> > + *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB4444;
> >> > + break;
> >> > +
> >> > + case DRM_FORMAT_ARGB1555:
> >> > + *mode = SUN4I_BACKEND_LAY_FBFMT_ARGB1555;
> >> > + break;
> >> > +
> >> > + case DRM_FORMAT_RGBA5551:
> >> > + *mode = SUN4I_BACKEND_LAY_FBFMT_RGBA5551;
> >> > + break;
> >> > +
> >> > + case DRM_FORMAT_RGBA4444:
> >> > + *mode = SUN4I_BACKEND_LAY_FBFMT_RGBA4444;
> >>
> >> The A20 manual only lists ARGB4444, not RGBA4444. There might be
> >> some discrepancy here. We can deal with them
> >
> > Hmm, yes, that's weird. But I guess this would be part of porting it
> > to the A20.
> >
> >> Also there are some more formats missing from the list, could you
> >> add them as well?
> >
> > Which one do you refer to?
>
> RGB556 and RGB655.
These formats are not supported by Linux yet though.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161027/0673d783/attachment.sig>
next prev parent reply other threads:[~2016-10-27 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 8:46 [PATCH] drm/sun4i: Add a few formats Maxime Ripard
2016-10-21 3:15 ` Chen-Yu Tsai
2016-10-24 14:40 ` Maxime Ripard
2016-10-25 0:42 ` Chen-Yu Tsai
2016-10-27 14:35 ` Maxime Ripard [this message]
2016-10-29 10:25 ` Chen-Yu Tsai
2016-11-02 18:55 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027143505.rblgbz5uqjynrtjk@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox