linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: leo.yan@linaro.org (Leo Yan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Date: Fri, 28 Oct 2016 18:19:19 +0800	[thread overview]
Message-ID: <20161028101919.GA25564@leoy-linaro> (raw)
In-Reply-To: <95e22336-0465-f1e1-71b8-548d0e6ee8b7@samsung.com>

On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:

[...]

> >>> Could you share the log? Is there any log about failure?
> >>
> >> Sure, please see below log:
> > 
> > It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller.
> > Maybe hi6220 has handled the reset controller(?)...
> > 
> > I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER..
> 
> Could you check the below thing..
> 
>         /* find reset controller when exist */
> -       pdata->rstc = devm_reset_control_get_optional(dev, NULL);
> +       pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>         if (IS_ERR(pdata->rstc)) {
>                 if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>                         return ERR_PTR(-EPROBE_DEFER);

Confirmed with this fixing, the kernel can bootup successfully.

Thanks for this.

> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller?
> 
> 
> Best Regards,
> Jaehoon Chung

  reply	other threads:[~2016-10-28 10:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  3:00 [PATCH v2 1/2] arm64: dts: hikey: extend default cma size to 128MB Guodong Xu
2016-08-25  3:00 ` [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Guodong Xu
2016-10-27 13:56   ` Vincent Guittot
2016-10-27 20:23     ` John Stultz
     [not found]       ` <CAKfTPtAXdkKcfpHmUmQNwuJxO0PORcCf49noST_CCkZPigPwgw@mail.gmail.com>
2016-10-28  7:26         ` Leo Yan
2016-10-28  7:33           ` Jaehoon Chung
2016-10-28  7:38             ` Leo Yan
2016-10-28  9:43               ` Jaehoon Chung
2016-10-28  9:54                 ` Jaehoon Chung
2016-10-28 10:19                   ` Leo Yan [this message]
2016-10-28 11:52                     ` Jaehoon Chung
2016-10-28 12:34                       ` Leo Yan
2016-10-28 21:12                         ` John Stultz
2016-08-30 15:56 ` [PATCH v2 1/2] arm64: dts: hikey: extend default cma size to 128MB Wei Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161028101919.GA25564@leoy-linaro \
    --to=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).