From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Wed, 2 Nov 2016 19:14:44 +0100 Subject: [PATCH] drm/sun4i: Fix error handling In-Reply-To: References: <20161030084926.15303-1-christophe.jaillet@wanadoo.fr> Message-ID: <20161102181444.hfrh6fcr2a5oe5n4@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Sun, Oct 30, 2016 at 12:53:02PM +0100, Christophe JAILLET wrote: > BTW, memory allocation in 'sun4i_layers_init()' looks spurious, especially > the use of 'layer' in the for loop. > Just my 2 cents. What do you mean by it's spurious? > I also forgot to say that we could propagate the error code returned by > sun4i_layers_init instead of returning -EINVAL unconditionally Indeed. Can you send a patch for that? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: