From mboxrd@z Thu Jan 1 00:00:00 1970 From: krzk@kernel.org (Krzysztof Kozlowski) Date: Thu, 3 Nov 2016 21:20:02 +0200 Subject: [PATCH v3 2/5] pinctrl: samsung: Add GPF support for Exynos5433 In-Reply-To: <1478155149-28527-3-git-send-email-cw00.choi@samsung.com> References: <1478155149-28527-1-git-send-email-cw00.choi@samsung.com> <1478155149-28527-3-git-send-email-cw00.choi@samsung.com> Message-ID: <20161103192002.GB12945@kozik-lap> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Nov 03, 2016 at 03:39:06PM +0900, Chanwoo Choi wrote: > This patch add the support of GPF[1-5] pin of Exynos5433 SoC. The GPFx need > to support the multiple memory map because the registers of GPFx are located > in the different domain. > > Cc: Tomasz Figa > Cc: Krzysztof Kozlowski > Cc: Sylwester Nawrocki > Cc: Kukjin Kim > Cc: Linus Walleij > Cc: Rob Herring > Cc: Mark Rutland > Cc: linux-gpio at vger.kernel.org > Signed-off-by: Joonyoung Shim > Signed-off-by: Chanwoo Choi > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 ++++++ > 1 file changed, 6 insertions(+) > I think that, instead of in previous patch, the "samsung,exynos5433-pinctrl" compatible should be documented here along with information that it requires two addresses for mappings. Best regards, Krzysztof > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c > index d657b52dfdb5..12f7d1eb65bc 100644 > --- a/drivers/pinctrl/samsung/pinctrl-exynos.c > +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c > @@ -1339,6 +1339,11 @@ static void exynos_pinctrl_resume(struct samsung_pinctrl_drv_data *drvdata) > EXYNOS_PIN_BANK_EINTW(8, 0x020, "gpa1", 0x04), > EXYNOS_PIN_BANK_EINTW(8, 0x040, "gpa2", 0x08), > EXYNOS_PIN_BANK_EINTW(8, 0x060, "gpa3", 0x0c), > + EXYNOS_PIN_BANK_EINTW_EXT(8, 0x020, "gpf1", 0x1004, 1), > + EXYNOS_PIN_BANK_EINTW_EXT(4, 0x040, "gpf2", 0x1008, 1), > + EXYNOS_PIN_BANK_EINTW_EXT(4, 0x060, "gpf3", 0x100c, 1), > + EXYNOS_PIN_BANK_EINTW_EXT(8, 0x080, "gpf4", 0x1010, 1), > + EXYNOS_PIN_BANK_EINTW_EXT(8, 0x0a0, "gpf5", 0x1014, 1), > }; > > /* pin banks of exynos5433 pin-controller - AUD */ > @@ -1420,6 +1425,7 @@ static void exynos_pinctrl_resume(struct samsung_pinctrl_drv_data *drvdata) > .eint_wkup_init = exynos_eint_wkup_init, > .suspend = exynos_pinctrl_suspend, > .resume = exynos_pinctrl_resume, > + .nr_ext_resources = 1, > }, { > /* pin-controller instance 1 data */ > .pin_banks = exynos5433_pin_banks1, > -- > 1.9.1 >