From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: dts: reference PM8058 as IRQ parent
Date: Thu, 3 Nov 2016 14:53:08 -0700 [thread overview]
Message-ID: <20161103215308.GU25787@tuxbot> (raw)
In-Reply-To: <1478164390-21613-2-git-send-email-linus.walleij@linaro.org>
On Thu 03 Nov 02:13 PDT 2016, Linus Walleij wrote:
> Some nodes are referencing the pm8058_gpio as IRQ parent, but
> the HW IRQ offset they are supplying is actually that for the
> parent to that controller: the PM8058 itself. Since that is the
> proper parent, reference it directly.
>
> We can switch this to the pm8058_gpio and the proper offset
> once we have fixed the SSBI GPIO driver to properly deal with
> the hierarchical IRQ domain and get proper local offset
> translation.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 4a532ddab53a..ea660ffa03ea 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -369,8 +369,8 @@
> ak8975 at 0c {
> compatible = "asahi-kasei,ak8975";
> reg = <0x0c>;
> - /* GPIO33 has interrupt 224 on the PM8058 */
> - interrupt-parent = <&pm8058_gpio>;
> + /* FIXME: GPIO33 has interrupt 224 on the PM8058 */
> + interrupt-parent = <&pm8058>;
> interrupts = <224 IRQ_TYPE_EDGE_RISING>;
> pinctrl-names = "default";
> pinctrl-0 = <&dragon_ak8975_gpios>;
> @@ -380,8 +380,8 @@
> bmp085 at 77 {
> compatible = "bosch,bmp085";
> reg = <0x77>;
> - /* GPIO16 has interrupt 207 on the PM8058 */
> - interrupt-parent = <&pm8058_gpio>;
> + /* FIXME: GPIO16 has interrupt 207 on the PM8058 */
> + interrupt-parent = <&pm8058>;
> interrupts = <207 IRQ_TYPE_EDGE_RISING>;
> reset-gpios = <&tlmm 86 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-11-03 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 9:13 [PATCH 1/3] ARM: dts: rename MSM8660/APQ8060 pmicintc to pm8058 Linus Walleij
2016-11-03 9:13 ` [PATCH 2/3] ARM: dts: reference PM8058 as IRQ parent Linus Walleij
2016-11-03 21:53 ` Bjorn Andersson [this message]
2016-11-03 9:13 ` [PATCH 3/3] ARM: dts: Add gyro and accel to APQ8060 Dragonboard Linus Walleij
2016-11-03 21:54 ` Bjorn Andersson
2016-11-03 21:50 ` [PATCH 1/3] ARM: dts: rename MSM8660/APQ8060 pmicintc to pm8058 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103215308.GU25787@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).