From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Fri, 4 Nov 2016 12:23:22 +0000 Subject: [PATCH 2/3] ARM: cache-uniphier: refactor jump label to follow coding style guideline In-Reply-To: <1478259816-24965-3-git-send-email-yamada.masahiro@socionext.com> References: <1478259816-24965-1-git-send-email-yamada.masahiro@socionext.com> <1478259816-24965-3-git-send-email-yamada.masahiro@socionext.com> Message-ID: <20161104122322.GB1041@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Nov 04, 2016 at 08:43:35PM +0900, Masahiro Yamada wrote: > Documentation/CodingStyle recommends to use label names which say > what the goto does or why the goto exists. > > Just in case, split it up into three labels because the CodingStyle > says "one err bugs" is a common type of bug (although, I do not > believe the current code includes such a bug). However, this has the effect of making the code unnecessarily more complicated, which is a bad thing. Avoiding unnecessary code complexity wins over style rules. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.