* [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-04 6:13 Christophe JAILLET
2016-11-04 7:48 ` Maxime Ripard
2016-11-07 1:19 ` Gustavo Padovan
0 siblings, 2 replies; 4+ messages in thread
From: Christophe JAILLET @ 2016-11-04 6:13 UTC (permalink / raw)
To: linux-arm-kernel
If 'sun4i_layers_init()' returns an error, propagate it instead of
returning -EINVAL unconditionally.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index 628712e6edd6..ee4e5f987b6f 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -145,7 +145,7 @@ static int sun4i_drv_bind(struct device *dev)
drv->layers = sun4i_layers_init(drm);
if (IS_ERR(drv->layers)) {
dev_err(drm->dev, "Couldn't create the planes\n");
- ret = -EINVAL;
+ ret = PTR_ERR(drv->layers);
goto free_drm;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] drm/sun4i: Propagate error to the caller
2016-11-04 6:13 [PATCH] drm/sun4i: Propagate error to the caller Christophe JAILLET
@ 2016-11-04 7:48 ` Maxime Ripard
2016-11-07 1:19 ` Gustavo Padovan
1 sibling, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2016-11-04 7:48 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 04, 2016 at 07:13:52AM +0100, Christophe JAILLET wrote:
> If 'sun4i_layers_init()' returns an error, propagate it instead of
> returning -EINVAL unconditionally.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161104/873dafd5/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/sun4i: Propagate error to the caller
2016-11-04 6:13 [PATCH] drm/sun4i: Propagate error to the caller Christophe JAILLET
2016-11-04 7:48 ` Maxime Ripard
@ 2016-11-07 1:19 ` Gustavo Padovan
2016-11-07 15:10 ` Maxime Ripard
1 sibling, 1 reply; 4+ messages in thread
From: Gustavo Padovan @ 2016-11-07 1:19 UTC (permalink / raw)
To: linux-arm-kernel
Hi Christophe,
2016-11-04 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
> If 'sun4i_layers_init()' returns an error, propagate it instead of
> returning -EINVAL unconditionally.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/sun4i: Propagate error to the caller
2016-11-07 1:19 ` Gustavo Padovan
@ 2016-11-07 15:10 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2016-11-07 15:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 07, 2016 at 10:19:57AM +0900, Gustavo Padovan wrote:
> Hi Christophe,
>
> 2016-11-04 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
>
> > If 'sun4i_layers_init()' returns an error, propagate it instead of
> > returning -EINVAL unconditionally.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161107/310f8f7b/attachment-0001.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-07 15:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-04 6:13 [PATCH] drm/sun4i: Propagate error to the caller Christophe JAILLET
2016-11-04 7:48 ` Maxime Ripard
2016-11-07 1:19 ` Gustavo Padovan
2016-11-07 15:10 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox