linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: krzk@kernel.org (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] ARM: dts: Extend the S3C RTC node with rtc_src clock
Date: Mon, 7 Nov 2016 19:44:11 +0200	[thread overview]
Message-ID: <20161107174411.GC4865@kozik-lap> (raw)
In-Reply-To: <1478513376-14307-7-git-send-email-pankaj.dubey@samsung.com>

On Mon, Nov 07, 2016 at 03:39:36PM +0530, Pankaj Dubey wrote:
> Extend the S3C RTC node with rtc_src clock so it could be operational.
> The rtc_src clock is provided by MAX8997.
> 
> CC: Rob Herring <robh+dt@kernel.org>
> CC: devicetree at vger.kernel.org
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4210-origen.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
> index 6c7ef4e..4cac9b6 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -18,6 +18,7 @@
>  #include "exynos4210.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/input/input.h>
> +#include <dt-bindings/clock/maxim,max8997.h>

Just a nit: put the system-wide includes in alphabetical order, so
clock, gpio and finally input. It helps reducing conflicting changes
(when more people add includes in the same time).

Beside that, looks good, but it requires a dt-bindings in separate patch
so I could pull it.

Best regards,
Krzysztof

  parent reply	other threads:[~2016-11-07 17:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 10:09 [PATCH 0/6] Add support for MAX8997 Clock Driver Pankaj Dubey
2016-11-07 10:09 ` [PATCH 1/6] mfd: max8997: Initialize max8997 register map Pankaj Dubey
2016-11-07 14:22   ` Javier Martinez Canillas
2016-11-07 17:12     ` Pankaj Dubey
2016-11-07 10:09 ` [PATCH 2/6] dt-bindings: clk: max8997: Add DT binding documentation Pankaj Dubey
2016-11-07 14:47   ` Javier Martinez Canillas
2016-11-14 16:15   ` Rob Herring
2016-11-17  2:17     ` pankaj.dubey
2016-11-07 10:09 ` [PATCH 3/6] clk: Add driver for Maxim-8997 PMIC clocks Pankaj Dubey
2016-11-07 15:01   ` Javier Martinez Canillas
2016-11-07 17:20     ` Pankaj Dubey
2016-11-07 17:41   ` Krzysztof Kozlowski
2016-11-07 10:09 ` [PATCH 4/6] ARM: dts: Add clock provider specific properties to max8997 node Pankaj Dubey
2016-11-07 15:07   ` Javier Martinez Canillas
2016-11-07 10:09 ` [PATCH 5/6] mfd: max8997: Add max8997-clk name in mfd_cell Pankaj Dubey
2016-11-07 15:08   ` Javier Martinez Canillas
2016-11-07 10:09 ` [PATCH 6/6] ARM: dts: Extend the S3C RTC node with rtc_src clock Pankaj Dubey
2016-11-07 15:09   ` Javier Martinez Canillas
2016-11-07 17:44   ` Krzysztof Kozlowski [this message]
2016-11-07 17:27 ` [PATCH 0/6] Add support for MAX8997 Clock Driver Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161107174411.GC4865@kozik-lap \
    --to=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).