Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 01/19] ARM: dts: armada-xp-matrix: Fix the location of the pcie-controller node
Date: Sun, 13 Nov 2016 22:23:44 +0100	[thread overview]
Message-ID: <20161113212402.3060-2-gregory.clement@free-electrons.com> (raw)
In-Reply-To: <20161113212402.3060-1-gregory.clement@free-electrons.com>

In the dts for the Marvell Armada XP Matrix board the pcie-controller was
located under the internal-regs node whereas it belongs to the soc node.

It means that, until this fix, the pcie could not work for this board
because it didn't match the definition of the pcie-controller node in the
dtsi file. If we had a look on the decompiled dtb file we saw two
different instances of the pcie-controller node: one with the all the
resource set but disabled and the other without any resource but enabled.

Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
 arch/arm/boot/dts/armada-xp-matrix.dts | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/armada-xp-matrix.dts b/arch/arm/boot/dts/armada-xp-matrix.dts
index 6522b04f4a8e..e1509f4c5114 100644
--- a/arch/arm/boot/dts/armada-xp-matrix.dts
+++ b/arch/arm/boot/dts/armada-xp-matrix.dts
@@ -71,6 +71,15 @@
 			  MBUS_ID(0x09, 0x09) 0 0 0xf1100000 0x10000
 			  MBUS_ID(0x09, 0x05) 0 0 0xf1110000 0x10000>;
 
+		pcie-controller {
+			status = "okay";
+
+			pcie at 1,0 {
+				/* Port 0, Lane 0 */
+				status = "okay";
+			};
+		};
+
 		internal-regs {
 			serial at 12000 {
 				status = "okay";
@@ -99,15 +108,6 @@
 				};
 			};
 
-			pcie-controller {
-				status = "okay";
-
-				pcie at 1,0 {
-					/* Port 0, Lane 0 */
-					status = "okay";
-				};
-			};
-
 			usb at 50000 {
 				status = "okay";
 			};
-- 
2.10.2

  reply	other threads:[~2016-11-13 21:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-13 21:23 [PATCH v2 00/19] Various Armada 370/XP DT warning fixup Gregory CLEMENT
2016-11-13 21:23 ` Gregory CLEMENT [this message]
2016-11-13 21:23 ` [PATCH v2 02/19] ARM: dts: armada-370-xp: move the cpurst node in the common file Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 03/19] ARM: dts: armada-370-xp: add node labels Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 04/19] ARM: dts: armada-370-xp: Use the " Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 05/19] ARM: dts: armada-370-xp: Fixup mdio DT warning Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 06/19] ARM: dts: armada-370-xp: Fixup bootrom " Gregory CLEMENT
2016-11-14  0:07   ` Rob Herring
2016-11-13 21:23 ` [PATCH v2 07/19] ARM: dts: armada-370-xp: Fixup devbus " Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 08/19] ARM: dts: armada-370-xp: Fixup bm-bppi " Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 09/19] ARM: dts: armada-370-xp: Fixup sa-ram " Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 10/19] ARM: dts: armada-xp: Fixup pcie DT warnings Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 11/19] ARM: dts: armada-370: " Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 12/19] ARM: dts: armada-370-xp: Remove skeleton.dtsi Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 13/19] ARM: dts: armada-370-xp: Fixup l2-cache DT warning Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 14/19] ARM: dts: armada-370-xp: Fixup internal-regs " Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 15/19] ARM: dts: armada-370-xp: Fixup soc " Gregory CLEMENT
2016-11-13 21:23 ` [PATCH v2 16/19] ARM: dts: armada-370-xp: Fixup memory " Gregory CLEMENT
2016-11-13 21:24 ` [PATCH v2 17/19] ARM: dts: armada-370-xp: Remove address from dsa unit name Gregory CLEMENT
2016-11-13 21:24 ` [PATCH v2 18/19] ARM: dts: armada-370-xp: Remove button address and fixup names Gregory CLEMENT
2016-11-13 21:24 ` [PATCH v2 19/19] ARM: dts: armada-370-xp: Fixup regulator DT warning Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161113212402.3060-2-gregory.clement@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox