From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h>
Date: Tue, 15 Nov 2016 15:50:45 +0000 [thread overview]
Message-ID: <20161115155045.GX1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20161107161448.GJ1041@n2100.armlinux.org.uk>
On Mon, Nov 07, 2016 at 04:14:48PM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 08, 2016 at 12:58:54AM +0900, Masahiro Yamada wrote:
> > Nothing in this header file depends on <linux/types.h>.
> > Rather, <linux/errno.h> should be included for -ENODEV.
>
> So how do we end up with a definition for u32?
>
> I think you need both these include files.
I've noticed you haven't responded to the above.
I've discarded the patch you've placed in the patch system in the hope
of a replacement with this comment addressed.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-11-15 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 15:58 [PATCH] ARM: cache-uniphier: include <linux/errno.h> instead of <linux/types.h> Masahiro Yamada
2016-11-07 16:14 ` Russell King - ARM Linux
2016-11-15 15:50 ` Russell King - ARM Linux [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-03 22:57 Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115155045.GX1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).