From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Wed, 16 Nov 2016 21:33:58 +0100 Subject: [PATCH] pinctrl: sunxi: fix theoretical uninitialized variable access In-Reply-To: <20161116141841.2030776-1-arnd@arndb.de> References: <20161116141841.2030776-1-arnd@arndb.de> Message-ID: <20161116203358.midi7vmaqirpywtt@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, On Wed, Nov 16, 2016 at 03:18:18PM +0100, Arnd Bergmann wrote: > gcc warns about a way that it could use an uninitialized variable: > > drivers/pinctrl/sunxi/pinctrl-sunxi.c: In function 'sunxi_pinctrl_init': > drivers/pinctrl/sunxi/pinctrl-sunxi.c:1191:8: error: 'best_div' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This cannot really happen except if 'freq' is UINT_MAX and 'clock' is > zero, and both of these are forbidden. To shut up the warning anyway, > this changes the logic to initialize the return code to the first > divider value before looking at the others. > > Fixes: 7c926492d38a ("pinctrl: sunxi: Add support for interrupt debouncing") > Signed-off-by: Arnd Bergmann Thanks for that patch. Just out of curiosity, which gcc gives those warnings? I have 6.2 and it didn't output anything.. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: