* [PATCH next] arm64: remove "SMP: Total of %d processors activated." message
@ 2016-11-17 7:32 Kefeng Wang
2016-11-17 14:22 ` Will Deacon
0 siblings, 1 reply; 5+ messages in thread
From: Kefeng Wang @ 2016-11-17 7:32 UTC (permalink / raw)
To: linux-arm-kernel
There is a common SMP boot message in generic code on all arches,
kill "SMP: Total of %d processors activated." in smp_cpus_done()
on arm64.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
Boot message on qemu.
[ 0.375116] smp: Brought up 1 node, 8 CPUs
[ 0.383749] SMP: Total of 8 processors activated.
arch/arm64/kernel/smp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index cb87234..9db4a95 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -428,7 +428,6 @@ static void __init hyp_mode_check(void)
void __init smp_cpus_done(unsigned int max_cpus)
{
- pr_info("SMP: Total of %d processors activated.\n", num_online_cpus());
setup_cpu_features();
hyp_mode_check();
apply_alternatives_all();
--
1.7.12.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH next] arm64: remove "SMP: Total of %d processors activated." message
2016-11-17 7:32 [PATCH next] arm64: remove "SMP: Total of %d processors activated." message Kefeng Wang
@ 2016-11-17 14:22 ` Will Deacon
2016-11-18 3:37 ` Kefeng Wang
0 siblings, 1 reply; 5+ messages in thread
From: Will Deacon @ 2016-11-17 14:22 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 17, 2016 at 03:32:26PM +0800, Kefeng Wang wrote:
> There is a common SMP boot message in generic code on all arches,
> kill "SMP: Total of %d processors activated." in smp_cpus_done()
> on arm64.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> Boot message on qemu.
> [ 0.375116] smp: Brought up 1 node, 8 CPUs
> [ 0.383749] SMP: Total of 8 processors activated.
>
> arch/arm64/kernel/smp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index cb87234..9db4a95 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -428,7 +428,6 @@ static void __init hyp_mode_check(void)
>
> void __init smp_cpus_done(unsigned int max_cpus)
> {
> - pr_info("SMP: Total of %d processors activated.\n", num_online_cpus());
> setup_cpu_features();
> hyp_mode_check();
> apply_alternatives_all();
Why? Are you proposing the same change to other architectures? Are you paid
per patch?
Will
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH next] arm64: remove "SMP: Total of %d processors activated." message
2016-11-17 14:22 ` Will Deacon
@ 2016-11-18 3:37 ` Kefeng Wang
2016-11-18 10:18 ` Will Deacon
0 siblings, 1 reply; 5+ messages in thread
From: Kefeng Wang @ 2016-11-18 3:37 UTC (permalink / raw)
To: linux-arm-kernel
On 2016/11/17 22:22, Will Deacon wrote:
> On Thu, Nov 17, 2016 at 03:32:26PM +0800, Kefeng Wang wrote:
>> There is a common SMP boot message in generic code on all arches,
>> kill "SMP: Total of %d processors activated." in smp_cpus_done()
>> on arm64.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> Boot message on qemu.
>> [ 0.375116] smp: Brought up 1 node, 8 CPUs
>> [ 0.383749] SMP: Total of 8 processors activated.
>>
>> arch/arm64/kernel/smp.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>> index cb87234..9db4a95 100644
>> --- a/arch/arm64/kernel/smp.c
>> +++ b/arch/arm64/kernel/smp.c
>> @@ -428,7 +428,6 @@ static void __init hyp_mode_check(void)
>>
>> void __init smp_cpus_done(unsigned int max_cpus)
>> {
>> - pr_info("SMP: Total of %d processors activated.\n", num_online_cpus());
>> setup_cpu_features();
>> hyp_mode_check();
>> apply_alternatives_all();
>
> Why? Are you proposing the same change to other architectures? Are you paid
> per patch?
The message provides no further information than the generic code, so kill it.
Or show BogoMIPS like arm32?
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index cb87234..6bb33cd 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -428,7 +428,17 @@ static void __init hyp_mode_check(void)
void __init smp_cpus_done(unsigned int max_cpus)
{
- pr_info("SMP: Total of %d processors activated.\n", num_online_cpus());
+ int cpu;
+ unsigned long bogosum = 0;
+
+ for_each_online_cpu(cpu)
+ bogosum += loops_per_jiffy;
+
+ pr_info("SMP: Total of %d processors activated "
+ "(%lu.%02lu BogoMIPS).\n",
+ num_online_cpus(),
+ bogosum / (500000/HZ),
+ (bogosum / (5000/HZ)) % 100);
setup_cpu_features();
hyp_mode_check();
apply_alternatives_all()
>
> Will
>
> .
>
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH next] arm64: remove "SMP: Total of %d processors activated." message
2016-11-18 3:37 ` Kefeng Wang
@ 2016-11-18 10:18 ` Will Deacon
2016-11-19 11:05 ` Russell King - ARM Linux
0 siblings, 1 reply; 5+ messages in thread
From: Will Deacon @ 2016-11-18 10:18 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 18, 2016 at 11:37:10AM +0800, Kefeng Wang wrote:
>
>
> On 2016/11/17 22:22, Will Deacon wrote:
> > On Thu, Nov 17, 2016 at 03:32:26PM +0800, Kefeng Wang wrote:
> >> There is a common SMP boot message in generic code on all arches,
> >> kill "SMP: Total of %d processors activated." in smp_cpus_done()
> >> on arm64.
> >>
> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> >> ---
> >> Boot message on qemu.
> >> [ 0.375116] smp: Brought up 1 node, 8 CPUs
> >> [ 0.383749] SMP: Total of 8 processors activated.
> >>
> >> arch/arm64/kernel/smp.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> >> index cb87234..9db4a95 100644
> >> --- a/arch/arm64/kernel/smp.c
> >> +++ b/arch/arm64/kernel/smp.c
> >> @@ -428,7 +428,6 @@ static void __init hyp_mode_check(void)
> >>
> >> void __init smp_cpus_done(unsigned int max_cpus)
> >> {
> >> - pr_info("SMP: Total of %d processors activated.\n", num_online_cpus());
> >> setup_cpu_features();
> >> hyp_mode_check();
> >> apply_alternatives_all();
> >
> > Why? Are you proposing the same change to other architectures? Are you paid
> > per patch?
>
> The message provides no further information than the generic code, so kill it.
> Or show BogoMIPS like arm32?
Ha! No, I don't think printing the BogoMIPS is the right solution. I just
think that, if you insist on removing the harmless print, then you should
also consider doing the same thing for all the other architectures that
print the same message.
Will
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH next] arm64: remove "SMP: Total of %d processors activated." message
2016-11-18 10:18 ` Will Deacon
@ 2016-11-19 11:05 ` Russell King - ARM Linux
0 siblings, 0 replies; 5+ messages in thread
From: Russell King - ARM Linux @ 2016-11-19 11:05 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 18, 2016 at 10:18:26AM +0000, Will Deacon wrote:
> On Fri, Nov 18, 2016 at 11:37:10AM +0800, Kefeng Wang wrote:
> > The message provides no further information than the generic code, so kill it.
> > Or show BogoMIPS like arm32?
>
> Ha! No, I don't think printing the BogoMIPS is the right solution. I just
> think that, if you insist on removing the harmless print, then you should
> also consider doing the same thing for all the other architectures that
> print the same message.
Note that I'd removed the redundant message from ARM a long time ago,
until Linus reverted the patch due to the /proc/cpuinfo part.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-19 11:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-17 7:32 [PATCH next] arm64: remove "SMP: Total of %d processors activated." message Kefeng Wang
2016-11-17 14:22 ` Will Deacon
2016-11-18 3:37 ` Kefeng Wang
2016-11-18 10:18 ` Will Deacon
2016-11-19 11:05 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).