linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH next] arm64: remove "SMP: Total of %d processors activated." message
Date: Fri, 18 Nov 2016 10:18:26 +0000	[thread overview]
Message-ID: <20161118101826.GC13470@arm.com> (raw)
In-Reply-To: <6d867f8f-c7b9-42e9-1764-6f802d6b1e96@huawei.com>

On Fri, Nov 18, 2016 at 11:37:10AM +0800, Kefeng Wang wrote:
> 
> 
> On 2016/11/17 22:22, Will Deacon wrote:
> > On Thu, Nov 17, 2016 at 03:32:26PM +0800, Kefeng Wang wrote:
> >> There is a common SMP boot message in generic code on all arches,
> >> kill "SMP: Total of %d processors activated." in smp_cpus_done()
> >> on arm64.
> >>
> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> >> ---
> >> Boot message on qemu.
> >> [    0.375116] smp: Brought up 1 node, 8 CPUs
> >> [    0.383749] SMP: Total of 8 processors activated.
> >>
> >>  arch/arm64/kernel/smp.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> >> index cb87234..9db4a95 100644
> >> --- a/arch/arm64/kernel/smp.c
> >> +++ b/arch/arm64/kernel/smp.c
> >> @@ -428,7 +428,6 @@ static void __init hyp_mode_check(void)
> >>  
> >>  void __init smp_cpus_done(unsigned int max_cpus)
> >>  {
> >> -	pr_info("SMP: Total of %d processors activated.\n", num_online_cpus());
> >>  	setup_cpu_features();
> >>  	hyp_mode_check();
> >>  	apply_alternatives_all();
> > 
> > Why? Are you proposing the same change to other architectures? Are you paid
> > per patch?
> 
> The message provides no further information than the generic code, so kill it.
> Or show BogoMIPS like arm32?

Ha! No, I don't think printing the BogoMIPS is the right solution. I just
think that, if you insist on removing the harmless print, then you should
also consider doing the same thing for all the other architectures that
print the same message.

Will

  reply	other threads:[~2016-11-18 10:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17  7:32 [PATCH next] arm64: remove "SMP: Total of %d processors activated." message Kefeng Wang
2016-11-17 14:22 ` Will Deacon
2016-11-18  3:37   ` Kefeng Wang
2016-11-18 10:18     ` Will Deacon [this message]
2016-11-19 11:05       ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161118101826.GC13470@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).