From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Wed, 23 Nov 2016 09:08:36 +0100 Subject: [PATCH v2 1/3] arm64: dts: add USB1-related nodes of Allwinner A64 In-Reply-To: <20161122155831.8724-1-icenowy@aosc.xyz> References: <20161122155831.8724-1-icenowy@aosc.xyz> Message-ID: <20161123080836.xigrwdmf4zxbqmqf@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 22, 2016 at 11:58:29PM +0800, Icenowy Zheng wrote: > Allwinner A64 have two HCI USB controllers, a OTG controller and a USB > PHY device which have two ports. One of the port is wired to both a HCI > USB controller and the OTG controller, which is currently not supported. > The another one is only wired to a HCI controller, and the device node of > OHCI/EHCI controller of the port can be added now. > > Also the A64 USB PHY device node is also added for the HCI controllers to > work. > > Signed-off-by: Icenowy Zheng > --- > Changes since v1: > - Remove manual CLK_USB_OHCI0 gate, as it's dealed by ccu driver now. > - Sort the nodes and fixed {e,o}hci1 regs. > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 44 +++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 3d70be3..2572dd6 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -122,6 +122,50 @@ > #size-cells = <1>; > ranges; > > + usbphy: phy at 01c19400 { > + compatible = "allwinner,sun50i-a64-usb-phy"; > + reg = <0x01c19400 0x14>, > + <0x01c1b800 0x4>; > + reg-names = "phy_ctrl", > + "pmu1"; > + clocks = <&ccu CLK_USB_PHY0>, > + <&ccu CLK_USB_PHY1>; > + clock-names = "usb0_phy", > + "usb1_phy"; > + resets = <&ccu RST_USB_PHY0>, > + <&ccu RST_USB_PHY1>; > + reset-names = "usb0_reset", > + "usb1_reset"; > + status = "disabled"; > + #phy-cells = <1>; > + }; > + > + ohci1: usb at 01c1b400 { > + compatible = "allwinner,sun50i-a64-ohci", "generic-ohci"; > + reg = <0x01c1b400 0x100>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_OHCI1>, > + <&ccu CLK_USB_OHCI1>; > + resets = <&ccu RST_BUS_OHCI1>; > + phys = <&usbphy 1>; > + phy-names = "usb"; > + status = "disabled"; > + }; > + > + ehci1: usb at 01c1b000 { > + compatible = "allwinner,sun50i-a64-ehci", "generic-ehci"; > + reg = <0x01c1b000 0x100>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_OHCI1>, > + <&ccu CLK_BUS_EHCI1>, > + <&ccu CLK_USB_OHCI1>; > + resets = <&ccu RST_BUS_OHCI1>, > + <&ccu RST_BUS_EHCI1>; > + phys = <&usbphy 1>; > + phy-names = "usb"; > + status = "disabled"; > + }; The nodes were inverted, also, please use "arm64: dts: allwinner:" for your prefix in the future. I fixed both issues and queued for 4.11. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: