linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v28 5/9] arm64: kdump: add VMCOREINFO's for user-space tools
Date: Thu, 24 Nov 2016 18:58:06 +0900	[thread overview]
Message-ID: <20161124095809.7092-4-takahiro.akashi@linaro.org> (raw)
In-Reply-To: <20161124095523.6972-1-takahiro.akashi@linaro.org>

In addition to common VMCOREINFO's defined in
crash_save_vmcoreinfo_init(), we need to know, for crash utility,
  - kimage_voffset
  - PHYS_OFFSET
to examine the contents of a dump file (/proc/vmcore) correctly
due to the introduction of KASLR (CONFIG_RANDOMIZE_BASE) in v4.6.

  - VA_BITS
is also required for makedumpfile command.

arch_crash_save_vmcoreinfo() appends them to the dump file.
More VMCOREINFO's may be added later.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: James Morse <james.morse@arm.com>
---
 arch/arm64/kernel/machine_kexec.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
index c60346d..994fe0b 100644
--- a/arch/arm64/kernel/machine_kexec.c
+++ b/arch/arm64/kernel/machine_kexec.c
@@ -17,6 +17,7 @@
 
 #include <asm/cacheflush.h>
 #include <asm/cpu_ops.h>
+#include <asm/memory.h>
 #include <asm/mmu_context.h>
 
 #include "cpu-reset.h"
@@ -260,3 +261,13 @@ void machine_crash_shutdown(struct pt_regs *regs)
 
 	pr_info("Starting crashdump kernel...\n");
 }
+
+void arch_crash_save_vmcoreinfo(void)
+{
+	VMCOREINFO_NUMBER(VA_BITS);
+	/* Please note VMCOREINFO_NUMBER() uses "%d", not "%x" */
+	vmcoreinfo_append_str("NUMBER(kimage_voffset)=0x%llx\n",
+						kimage_voffset);
+	vmcoreinfo_append_str("NUMBER(PHYS_OFFSET)=0x%llx\n",
+						PHYS_OFFSET);
+}
-- 
2.10.0

  parent reply	other threads:[~2016-11-24  9:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24  9:55 [PATCH v28 0/9] arm64: add kdump support AKASHI Takahiro
2016-11-24  9:57 ` [PATCH v28 1/9] memblock: add memblock_cap_memory_range() AKASHI Takahiro
2016-11-24 10:26   ` Catalin Marinas
2016-11-24  9:58 ` [PATCH v28 2/9] arm64: limit memory regions based on DT property, usable-memory-range AKASHI Takahiro
2016-11-24  9:58 ` [PATCH v28 3/9] arm64: kdump: reserve memory for crash dump kernel AKASHI Takahiro
2016-11-24  9:58 ` [PATCH v28 4/9] arm64: kdump: implement machine_crash_shutdown() AKASHI Takahiro
2016-11-28 15:04   ` Catalin Marinas
2016-11-29  5:47     ` AKASHI Takahiro
2016-11-24  9:58 ` AKASHI Takahiro [this message]
2016-11-24  9:58 ` [PATCH v28 6/9] arm64: kdump: provide /proc/vmcore file AKASHI Takahiro
2016-11-24  9:58 ` [PATCH v28 7/9] arm64: kdump: enable kdump in defconfig AKASHI Takahiro
2016-11-24  9:58 ` [PATCH v28 8/9] Documentation: kdump: describe arm64 port AKASHI Takahiro
2016-11-24  9:59 ` [PATCH v28 9/9] Documentation: dt: chosen properties for arm64 kdump AKASHI Takahiro
2016-11-24 17:14   ` Catalin Marinas
2016-11-30 20:44     ` Rob Herring
2016-11-25 16:20 ` [PATCH v28 0/9] arm64: add kdump support Catalin Marinas
2016-11-29 11:05   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161124095809.7092-4-takahiro.akashi@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).