From: robert.richter@cavium.com (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: mm: Fix memmap to be initialized for the entire section
Date: Thu, 24 Nov 2016 15:11:49 +0100 [thread overview]
Message-ID: <20161124141149.GE2213@rric.localdomain> (raw)
In-Reply-To: <CAKv+Gu9qB7P2epMGdwFJ3vJR3vt-bBxU0nKwmKdpaOpTKdqzzA@mail.gmail.com>
On 24.11.16 13:58:30, Ard Biesheuvel wrote:
> On 24 November 2016 at 13:51, Robert Richter <robert.richter@cavium.com> wrote:
> > On 24.11.16 13:44:31, Ard Biesheuvel wrote:
> >> On 24 November 2016 at 13:42, Robert Richter <robert.richter@cavium.com> wrote:
> >> > On 23.11.16 21:25:06, Ard Biesheuvel wrote:
> >> >> Why? MEMREMAP_WB is used often, among other things for mapping
> >> >> firmware tables, which are marked as NOMAP, so in these cases, the
> >> >> linear address is not mapped.
> >> >
> >> > If fw tables are mapped wb, that is wrong and needs a separate fix.
> >> >
> >>
> >> Why is that wrong?
> >
> > The whole issue with mapping acpi tables is not marking them cachable,
> > what wb does.
>
> What 'issue'?
>
> > Otherwise we could just use linear mapping for those mem
> > ranges.
> >
>
> Regions containing firmware tables are owned by the firmware, and it
> is the firmware that tells us which memory attributes we are allowed
> to use. If those attributes include WB, it is perfectly legal to use a
> cacheable mapping. That does *not* mean they should be covered by the
> linear mapping. The linear mapping is read-write-non-exec, for
> instance, and we may prefer to use a read-only mapping and/or
> executable mapping.
Ok, I am going to fix try_ram_remap().
Are there other concerns with this patch?
Thanks,
-Robert
next prev parent reply other threads:[~2016-11-24 14:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 9:52 [PATCH] arm64: mm: Fix memmap to be initialized for the entire section Robert Richter
2016-10-06 10:00 ` Ard Biesheuvel
2016-10-06 16:11 ` Robert Richter
2016-10-17 18:58 ` Robert Richter
2016-10-27 16:01 ` Will Deacon
2016-10-28 9:19 ` Robert Richter
2016-11-07 21:05 ` Will Deacon
2016-11-09 19:51 ` Robert Richter
2016-11-17 14:25 ` Will Deacon
2016-11-17 15:18 ` Robert Richter
2016-11-20 17:07 ` Ard Biesheuvel
2016-11-23 21:15 ` Robert Richter
2016-11-23 21:25 ` Ard Biesheuvel
2016-11-24 13:42 ` Robert Richter
2016-11-24 13:44 ` Ard Biesheuvel
2016-11-24 13:51 ` Robert Richter
2016-11-24 13:58 ` Ard Biesheuvel
2016-11-24 14:11 ` Robert Richter [this message]
2016-11-24 14:23 ` Ard Biesheuvel
2016-11-24 15:09 ` Robert Richter
2016-11-24 19:26 ` Robert Richter
2016-11-24 19:42 ` Ard Biesheuvel
2016-11-25 11:29 ` Robert Richter
2016-11-25 12:28 ` Ard Biesheuvel
2016-11-25 17:01 ` Ard Biesheuvel
2016-10-18 10:18 ` Mark Rutland
2016-10-18 15:02 ` Robert Richter
2016-10-10 15:33 ` David Daney
2016-11-01 16:55 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124141149.GE2213@rric.localdomain \
--to=robert.richter@cavium.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox